From fb6e06952c1fea3c967ce676e518252e74753437 Mon Sep 17 00:00:00 2001
From: Louis Seubert <louis.seubert.ls@gmail.com>
Date: Wed, 1 May 2024 17:55:07 +0200
Subject: [PATCH] feat: fix inconsistent naming of transformation functions

Fix naming of transformation functions like `Nap` and `Then` when handling `Task` or `ValueTask` as a result of the transformation. If the transformation function supplied to the `Map` or `Then` function returns a `Task` or `ValueTask`, now these functions always have the `Async` suffix in their name.
If the function is an extension function which operates on a `Task<Result<T>>` or `ValueTask<Result<T>>` and does not fulfil the contracts with the task result of the transformation, the function does **not** have the `Async` suffix.
---
 src/Result/Extensions/Extensions.Task.cs | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/Result/Extensions/Extensions.Task.cs b/src/Result/Extensions/Extensions.Task.cs
index b260621..70e695e 100644
--- a/src/Result/Extensions/Extensions.Task.cs
+++ b/src/Result/Extensions/Extensions.Task.cs
@@ -22,13 +22,14 @@ public static partial class Extensions
 	/// <returns>A new result containing either the mapped success value or the failure value of the original
 	/// result.</returns>
 	[MethodImpl(MethodImplOptions.AggressiveInlining)]
+	// ReSharper disable once InconsistentNaming
 	public static async ValueTask<Result<TNew>> Map<T, TNew>(this Task<Result<T>> result,
 		Func<T, TNew> func)
 		=> (await result).Map(func);
 
 	/// <inheritdoc cref="Map{T,TNew}(System.Threading.Tasks.Task{Geekeey.Extensions.Result.Result{T}},System.Func{T,TNew})"/>
 	[MethodImpl(MethodImplOptions.AggressiveInlining)]
-	public static async Task<Result<TNew>> Map<T, TNew>(this Task<Result<T>> result,
+	public static async Task<Result<TNew>> MapAsync<T, TNew>(this Task<Result<T>> result,
 		Func<T, ValueTask<TNew>> func)
 		=> await (await result).MapAsync(func);
 
@@ -43,13 +44,14 @@ public static partial class Extensions
 	/// <returns>A new result containing either the mapped success value or the failure value of the original
 	/// result.</returns>
 	[MethodImpl(MethodImplOptions.AggressiveInlining)]
+	// ReSharper disable once InconsistentNaming
 	public static async Task<Result<TNew>> Then<T, TNew>(this Task<Result<T>> result,
 		Func<T, Result<TNew>> func)
 		=> (await result).Then(func);
 
 	/// <inheritdoc cref="Then{T,TNew}(System.Threading.Tasks.Task{Geekeey.Extensions.Result.Result{T}},System.Func{T,Geekeey.Extensions.Result.Result{TNew}})"/>
 	[MethodImpl(MethodImplOptions.AggressiveInlining)]
-	public static async Task<Result<TNew>> Then<T, TNew>(this Task<Result<T>> result,
+	public static async Task<Result<TNew>> ThenAsync<T, TNew>(this Task<Result<T>> result,
 		Func<T, ValueTask<Result<TNew>>> func)
 		=> await (await result).ThenAsync(func);
 
@@ -59,25 +61,27 @@ public static partial class Extensions
 
 	/// <inheritdoc cref="Map{T,TNew}(System.Threading.Tasks.Task{Geekeey.Extensions.Result.Result{T}},System.Func{T,TNew})"/>
 	[MethodImpl(MethodImplOptions.AggressiveInlining)]
+	// ReSharper disable once InconsistentNaming
 	public static async Task<Result<TNew>> Map<T, TNew>(this ValueTask<Result<T>> result,
 		Func<T, TNew> func)
 		=> (await result).Map(func);
 
 	/// <inheritdoc cref="Map{T,TNew}(System.Threading.Tasks.Task{Geekeey.Extensions.Result.Result{T}},System.Func{T,TNew})"/>
 	[MethodImpl(MethodImplOptions.AggressiveInlining)]
-	public static async ValueTask<Result<TNew>> Map<T, TNew>(this ValueTask<Result<T>> result,
+	public static async ValueTask<Result<TNew>> MapAsync<T, TNew>(this ValueTask<Result<T>> result,
 		Func<T, ValueTask<TNew>> func)
 		=> await (await result).MapAsync(func);
 
 	/// <inheritdoc cref="Then{T,TNew}(System.Threading.Tasks.Task{Geekeey.Extensions.Result.Result{T}},System.Func{T,Geekeey.Extensions.Result.Result{TNew}})"/>
 	[MethodImpl(MethodImplOptions.AggressiveInlining)]
+	// ReSharper disable once InconsistentNaming
 	public static async ValueTask<Result<TNew>> Then<T, TNew>(this ValueTask<Result<T>> result,
 		Func<T, Result<TNew>> func)
 		=> (await result).Then(func);
 
 	/// <inheritdoc cref="Then{T,TNew}(System.Threading.Tasks.Task{Geekeey.Extensions.Result.Result{T}},System.Func{T,Geekeey.Extensions.Result.Result{TNew}})"/>
 	[MethodImpl(MethodImplOptions.AggressiveInlining)]
-	public static async ValueTask<Result<TNew>> Then<T, TNew>(this ValueTask<Result<T>> result,
+	public static async ValueTask<Result<TNew>> ThenAsync<T, TNew>(this ValueTask<Result<T>> result,
 		Func<T, ValueTask<Result<TNew>>> func)
 		=> await (await result).ThenAsync(func);