From 01389100771bb130d3451f0c1331744de9fa140c Mon Sep 17 00:00:00 2001
From: Eric Liu <ericyl.us@gmail.com>
Date: Mon, 14 Sep 2020 07:20:48 -0700
Subject: [PATCH] fix(pagination): convert page variable to number type

The Select component coerces the page value into a string, which affects other components.
---
 src/Pagination/Pagination.Story.svelte |  8 +++++++-
 src/Pagination/Pagination.svelte       | 11 ++++++++++-
 2 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/src/Pagination/Pagination.Story.svelte b/src/Pagination/Pagination.Story.svelte
index 217ffd12..acbf7fb5 100644
--- a/src/Pagination/Pagination.Story.svelte
+++ b/src/Pagination/Pagination.Story.svelte
@@ -12,6 +12,12 @@
   {:else if story === 'skeleton'}
     <PaginationSkeleton />
   {:else}
-    <Pagination {...$$props}>Pagination</Pagination>
+    <Pagination
+      {...$$props}
+      on:update="{({ detail }) => {
+        console.log(detail);
+      }}">
+      Pagination
+    </Pagination>
   {/if}
 </div>
diff --git a/src/Pagination/Pagination.svelte b/src/Pagination/Pagination.svelte
index 83af6f2e..3e9145bb 100644
--- a/src/Pagination/Pagination.svelte
+++ b/src/Pagination/Pagination.svelte
@@ -100,9 +100,18 @@
   const dispatch = createEventDispatcher();
 
   afterUpdate(() => {
-    dispatch("update", { pageSize: parseInt(pageSize), page: parseInt(page) });
+    dispatch("update", { pageSize, page });
   });
 
+  $: {
+    if (typeof page !== "number") {
+      page = Number(page);
+    }
+
+    if (typeof pageSize !== "number") {
+      pageSize = Number(pageSize);
+    }
+  }
   $: totalPages = Math.max(Math.ceil(totalItems / pageSize), 1);
   $: selectItems = Array.from({ length: totalPages }, (_, i) => i);
   $: backButtonDisabled = disabled || page === 1;