mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-15 02:11:05 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix(tree-view): loosen TreeNode text property type to any (#1576)

Browse source 
* fix(tree-view): loosen `TreeNode` text property type to any

* Run "yarn build:docs"

* test(tree-view): assert updated property type value
This commit is contained in:
metonym 2022-12-07 20:00:20 -08:00 • committed by GitHub
commit 198e0da4c5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 8 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
COMPONENT_INDEX.md
View file

@ -4654,7 +4654,7 @@ export type TreeNodeId = string | number;
export interface TreeNode { export interface TreeNode {
id: TreeNodeId; id: TreeNodeId;
text: string; text: any;
icon?: typeof import("svelte").SvelteComponent; icon?: typeof import("svelte").SvelteComponent;
disabled?: boolean; disabled?: boolean;
expanded?: boolean; expanded?: boolean;

4
docs/src/COMPONENT_API.json
View file

@ -14483,9 +14483,9 @@
"ts": "type TreeNodeId = string | number" "ts": "type TreeNodeId = string | number"
}, },
{ {
"type": "{ id: TreeNodeId; text: string; icon?: typeof import(\"svelte\").SvelteComponent; disabled?: boolean; expanded?: boolean; children?: TreeNode[]; }", "type": "{ id: TreeNodeId; text: any; icon?: typeof import(\"svelte\").SvelteComponent; disabled?: boolean; expanded?: boolean; children?: TreeNode[]; }",
"name": "TreeNode", "name": "TreeNode",
"ts": "interface TreeNode { id: TreeNodeId; text: string; icon?: typeof import(\"svelte\").SvelteComponent; disabled?: boolean; expanded?: boolean; children?: TreeNode[]; }" "ts": "interface TreeNode { id: TreeNodeId; text: any; icon?: typeof import(\"svelte\").SvelteComponent; disabled?: boolean; expanded?: boolean; children?: TreeNode[]; }"
} }
], ],
"rest_props": { "type": "Element", "name": "ul" } "rest_props": { "type": "Element", "name": "ul" }

2
src/TreeView/TreeView.svelte
View file

@ -1,7 +1,7 @@
<script> <script>
/** /**
* @typedef {string | number} TreeNodeId * @typedef {string | number} TreeNodeId
* @typedef {{ id: TreeNodeId; text: string; icon?: typeof import("svelte").SvelteComponent; disabled?: boolean; expanded?: boolean; children?: TreeNode[]; }} TreeNode * @typedef {{ id: TreeNodeId; text: any; icon?: typeof import("svelte").SvelteComponent; disabled?: boolean; expanded?: boolean; children?: TreeNode[]; }} TreeNode
* @event {TreeNode & { expanded: boolean; leaf: boolean; }} select * @event {TreeNode & { expanded: boolean; leaf: boolean; }} select
* @event {TreeNode & { expanded: boolean; leaf: boolean; }} toggle * @event {TreeNode & { expanded: boolean; leaf: boolean; }} toggle
* @event {TreeNode & { expanded: boolean; leaf: boolean; }} focus * @event {TreeNode & { expanded: boolean; leaf: boolean; }} focus

5
tests/TreeView.test.svelte
View file

@ -1,4 +1,5 @@
<script lang="ts"> <script lang="ts">
import type { ComponentProps } from "svelte";
import { TreeView } from "../types"; import { TreeView } from "../types";
import type { TreeNodeId } from "../types/TreeView/TreeView.svelte"; import type { TreeNodeId } from "../types/TreeView/TreeView.svelte";
import Analytics from "carbon-icons-svelte/lib/Analytics.svelte"; import Analytics from "carbon-icons-svelte/lib/Analytics.svelte";
@ -7,11 +8,11 @@
let activeId: TreeNodeId = ""; let activeId: TreeNodeId = "";
let selectedIds = []; let selectedIds = [];
let expandedIds = [1]; let expandedIds = [1];
let children = [ let children: ComponentProps<TreeView>["children"] = [
{ id: 0, text: "AI / Machine learning", icon: Analytics }, { id: 0, text: "AI / Machine learning", icon: Analytics },
{ {
id: 1, id: 1,
text: "Analytics", text: 0,
children: [ children: [
{ {
id: 2, id: 2,

2
types/TreeView/TreeView.svelte.d.ts vendored
View file

@ -5,7 +5,7 @@ export type TreeNodeId = string | number;
export interface TreeNode { export interface TreeNode {
id: TreeNodeId; id: TreeNodeId;
text: string; text: any;
icon?: typeof import("svelte").SvelteComponent; icon?: typeof import("svelte").SvelteComponent;
disabled?: boolean; disabled?: boolean;
expanded?: boolean; expanded?: boolean;