From 1e5333dd64d24ce4b6fa39c3521a56f3ba79efc8 Mon Sep 17 00:00:00 2001 From: Eric Liu Date: Sun, 19 Jul 2020 06:33:06 -0700 Subject: [PATCH] refactor(ui-shell): use $$restProps, remove cx --- src/components/UIShell/Content.svelte | 2 +- src/components/UIShell/FormTest.svelte | 16 ---- .../UIShell/GlobalHeader/Header.svelte | 14 +-- .../UIShell/GlobalHeader/HeaderAction.svelte | 64 +++++++------ .../GlobalHeader/HeaderActionLink.svelte | 15 +-- .../GlobalHeader/HeaderActionSearch.svelte | 84 ++++++++-------- .../UIShell/GlobalHeader/HeaderNav.svelte | 5 +- .../UIShell/GlobalHeader/HeaderNavItem.svelte | 10 +- .../UIShell/GlobalHeader/HeaderNavMenu.svelte | 52 +++++----- .../GlobalHeader/HeaderPanelDivider.svelte | 1 + .../GlobalHeader/HeaderPanelLink.svelte | 8 +- .../GlobalHeader/HeaderPanelLinks.svelte | 6 +- .../GlobalHeader/HeaderUtilities.svelte | 6 +- .../UIShell/SideNav/HamburgerMenu.svelte | 37 +++---- src/components/UIShell/SideNav/SideNav.svelte | 12 +-- .../UIShell/SideNav/SideNavItems.svelte | 6 +- .../UIShell/SideNav/SideNavLink.svelte | 17 ++-- .../UIShell/SideNav/SideNavMenu.svelte | 38 ++++---- .../UIShell/SideNav/SideNavMenuItem.svelte | 13 ++- src/components/UIShell/UIShell.stories.js | 66 ++++++------- src/components/UIShell/constants.js | 96 ------------------- src/components/UIShell/helpers.js | 21 ---- src/components/UIShell/index.js | 36 +++---- src/lib/__tests__/cx.spec.js | 10 -- src/lib/cx.js | 19 ---- src/lib/index.js | 1 - 26 files changed, 230 insertions(+), 425 deletions(-) delete mode 100644 src/components/UIShell/FormTest.svelte delete mode 100644 src/components/UIShell/constants.js delete mode 100644 src/components/UIShell/helpers.js delete mode 100644 src/lib/__tests__/cx.spec.js delete mode 100644 src/lib/cx.js delete mode 100644 src/lib/index.js diff --git a/src/components/UIShell/Content.svelte b/src/components/UIShell/Content.svelte index 24172e31..ef98f184 100644 --- a/src/components/UIShell/Content.svelte +++ b/src/components/UIShell/Content.svelte @@ -2,6 +2,6 @@ export let id = "main-content"; -
+
diff --git a/src/components/UIShell/FormTest.svelte b/src/components/UIShell/FormTest.svelte deleted file mode 100644 index b5b2e5c8..00000000 --- a/src/components/UIShell/FormTest.svelte +++ /dev/null @@ -1,16 +0,0 @@ - - - -
-
- -
-
- -
-
- diff --git a/src/components/UIShell/GlobalHeader/Header.svelte b/src/components/UIShell/GlobalHeader/Header.svelte index 27773498..06ac6789 100644 --- a/src/components/UIShell/GlobalHeader/Header.svelte +++ b/src/components/UIShell/GlobalHeader/Header.svelte @@ -5,23 +5,23 @@ export let platformName = undefined; export let isSideNavOpen = undefined; - import { cx } from '../../../lib'; - import HamburgerMenu from '../SideNav/HamburgerMenu.svelte'; + import HamburgerMenu from "../SideNav/HamburgerMenu.svelte"; let winWidth = undefined; - $: isSideNavOpen = winWidth >= 1056; - $: ariaLabel = company + (uiShellAriaLabel || $$props['aria-label'] || platformName); + $: isSideNavOpen = winWidth >= 1056; + $: ariaLabel = + company + (uiShellAriaLabel || $$props["aria-label"] || platformName); -