mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-15 10:21:05 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix(number-input): empty input should not be coerced to 0 (#1032)

Browse source 
Fixes #1031
This commit is contained in:
Eric Liu 2022-01-22 08:58:48 -08:00 • committed by GitHub
commit 222d5a90e4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/NumberInput/NumberInput.svelte
View file

@ -131,10 +131,15 @@
let inputValue = value; let inputValue = value;
const normalizeValue = (_value) => {
if (_value === undefined || _value === "") return _value;
return Number(_value);
};
$: dispatch("change", value); $: dispatch("change", value);
$: incrementLabel = translateWithId("increment"); $: incrementLabel = translateWithId("increment");
$: decrementLabel = translateWithId("decrement"); $: decrementLabel = translateWithId("decrement");
$: value = Number(inputValue); $: value = normalizeValue(inputValue);
$: error = $: error =
invalid || (!allowEmpty && value === "") || value > max || value < min; invalid || (!allowEmpty && value === "") || value > max || value < min;
$: errorId = `error-${id}`; $: errorId = `error-${id}`;