From 29a83c325ccfdac80c1111bd62d5d79cd916200c Mon Sep 17 00:00:00 2001
From: Enrico Sacchetti <enrico@theetrain.ca>
Date: Mon, 26 Sep 2022 16:35:57 -0400
Subject: [PATCH] feat(select): forward change event

Dispatch `input` instead of `change` when props change internally
since `change` is a user event and `input` is an internal event
---
 COMPONENT_INDEX.md              | 4 ++--
 docs/src/COMPONENT_API.json     | 4 ++--
 src/Select/Select.svelte        | 5 +++--
 types/Select/Select.svelte.d.ts | 4 ++--
 4 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/COMPONENT_INDEX.md b/COMPONENT_INDEX.md
index 35693a94..13d60824 100644
--- a/COMPONENT_INDEX.md
+++ b/COMPONENT_INDEX.md
@@ -3179,8 +3179,8 @@ None.
 
 | Event name | Type       | Detail                            |
 | :--------- | :--------- | :-------------------------------- |
-| change     | dispatched | <code>string &#124; number</code> |
-| input      | forwarded  | --                                |
+| input      | dispatched | <code>string &#124; number</code> |
+| change     | forwarded  | --                                |
 | focus      | forwarded  | --                                |
 | blur       | forwarded  | --                                |
 
diff --git a/docs/src/COMPONENT_API.json b/docs/src/COMPONENT_API.json
index b870e435..10cbccbd 100644
--- a/docs/src/COMPONENT_API.json
+++ b/docs/src/COMPONENT_API.json
@@ -10252,8 +10252,8 @@
         }
       ],
       "events": [
-        { "type": "dispatched", "name": "change", "detail": "string | number" },
-        { "type": "forwarded", "name": "input", "element": "select" },
+        { "type": "dispatched", "name": "input", "detail": "string | number" },
+        { "type": "forwarded", "name": "change", "element": "select" },
         { "type": "forwarded", "name": "focus", "element": "select" },
         { "type": "forwarded", "name": "blur", "element": "select" }
       ],
diff --git a/src/Select/Select.svelte b/src/Select/Select.svelte
index dfaf8861..d95035a8 100644
--- a/src/Select/Select.svelte
+++ b/src/Select/Select.svelte
@@ -1,6 +1,6 @@
 <script>
   /**
-   * @event {string | number} change
+   * @event {string | number} input
    */
 
   /**
@@ -114,7 +114,7 @@
     selected = $selectedValue;
 
     if (prevSelected !== undefined && selected !== prevSelected) {
-      dispatch("change", $selectedValue);
+      dispatch("input", $selectedValue);
     }
 
     prevSelected = selected;
@@ -163,6 +163,7 @@
             class:bx--select-input--sm="{size === 'sm'}"
             class:bx--select-input--xl="{size === 'xl'}"
             on:change="{handleChange}"
+            on:change
             on:input
             on:focus
             on:blur
diff --git a/types/Select/Select.svelte.d.ts b/types/Select/Select.svelte.d.ts
index 6c5a57ff..40a2f15c 100644
--- a/types/Select/Select.svelte.d.ts
+++ b/types/Select/Select.svelte.d.ts
@@ -109,8 +109,8 @@ export interface SelectProps
 export default class Select extends SvelteComponentTyped<
   SelectProps,
   {
-    change: CustomEvent<string | number>;
-    input: WindowEventMap["input"];
+    input: CustomEvent<string | number>;
+    change: WindowEventMap["change"];
     focus: WindowEventMap["focus"];
     blur: WindowEventMap["blur"];
   },