mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-15 10:21:05 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix(ComposedModal): remove bx--body--with-modal-open from body classes after destroy

Browse source 
When onMount is async, the returned function is not executed: https://github.com/sveltejs/svelte/issues/4927
Because the class is not remove from the body, the code should be moved to a onDestroy function.
This commit is contained in:
weaseldotro 2020-10-20 11:09:33 +03:00 • committed by GitHub
commit 2afb888485
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/ComposedModal/ComposedModal.svelte
View file

@ -47,6 +47,7 @@
setContext,
onMount,
afterUpdate,
onDestroy,
} from "svelte";
const dispatch = createEventDispatcher();
@ -79,12 +80,12 @@
onMount(async () => {
await tick();
focus();
return () => {
document.body.classList.remove("bx--body--with-modal-open");
};
});
onDestroy(() => {
document.body.classList.remove("bx--body--with-modal-open");
})
afterUpdate(() => {
if (opened) {
if (!open) {