From 2c79f1637169987340bfcd45756f9c9decc7503c Mon Sep 17 00:00:00 2001 From: Bilux Date: Sun, 14 Nov 2021 21:03:47 +0100 Subject: [PATCH] Fix some minor bugs The tabindex variable is of a number type (it should be fixed in all components?) Add href to link attributes to get rid of "" --- src/OverflowMenu/OverflowMenuItem.svelte | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/OverflowMenu/OverflowMenuItem.svelte b/src/OverflowMenu/OverflowMenuItem.svelte index de4e1386..ac81cadd 100644 --- a/src/OverflowMenu/OverflowMenuItem.svelte +++ b/src/OverflowMenu/OverflowMenuItem.svelte @@ -44,7 +44,7 @@ $: primaryFocus = $focusedId === id; $: buttonProps = { role: "menuitem", - tabindex: "-1", + tabindex: -1, class: "bx--overflow-menu-options__btn", disabled: href ? undefined : disabled, href: href ? href : undefined, @@ -62,9 +62,9 @@ {...$$restProps} > {#if href} -