From 32077693e093623525c0fa9ffc24aa9f05b6306f Mon Sep 17 00:00:00 2001
From: josefaidt <josef.aidt@gmail.com>
Date: Thu, 8 Oct 2020 14:02:08 -0500
Subject: [PATCH] chore(links): add rel="" to all links

---
 src/Button/Button.Skeleton.svelte                | 1 +
 src/Button/Button.svelte                         | 1 +
 src/Link/Link.svelte                             | 2 +-
 src/Tile/ClickableTile.svelte                    | 1 +
 src/UIShell/GlobalHeader/HeaderActionLink.svelte | 3 ++-
 src/UIShell/GlobalHeader/HeaderPanelLink.svelte  | 1 +
 src/UIShell/SideNav/SideNavLink.svelte           | 1 +
 7 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/Button/Button.Skeleton.svelte b/src/Button/Button.Skeleton.svelte
index 68860916..7002a0c8 100644
--- a/src/Button/Button.Skeleton.svelte
+++ b/src/Button/Button.Skeleton.svelte
@@ -15,6 +15,7 @@
 {#if href}
   <a
     href="{href}"
+    rel="{$$restProps.target === '_blank' ? 'noopener noreferrer' : undefined}"
     role="button"
     class:bx--skeleton="{true}"
     class:bx--btn="{true}"
diff --git a/src/Button/Button.svelte b/src/Button/Button.svelte
index 74f7389d..4ec4d691 100644
--- a/src/Button/Button.svelte
+++ b/src/Button/Button.svelte
@@ -123,6 +123,7 @@
 {#if skeleton}
   <ButtonSkeleton
     href="{href}"
+    rel="{$$restProps.target === '_blank' ? 'noopener noreferrer' : undefined}"
     small="{size === 'small'}"
     {...$$restProps}
     style="{hasIconOnly && 'width: 3rem;'}"
diff --git a/src/Link/Link.svelte b/src/Link/Link.svelte
index 8ac00f0c..8b1a644d 100644
--- a/src/Link/Link.svelte
+++ b/src/Link/Link.svelte
@@ -54,7 +54,7 @@
     class:bx--link--inline="{inline}"
     class:bx--link--visited="{visited}"
     rel="{$$restProps.target === '_blank' ? 'noopener noreferrer' : undefined}"
-    {href}
+    href="{href}"
     {...$$restProps}
     on:click
     on:mouseover
diff --git a/src/Tile/ClickableTile.svelte b/src/Tile/ClickableTile.svelte
index e5fca1e3..a1ded7ed 100644
--- a/src/Tile/ClickableTile.svelte
+++ b/src/Tile/ClickableTile.svelte
@@ -26,6 +26,7 @@
   class:bx--tile--light="{light}"
   {...$$restProps}
   href="{href}"
+  rel=""
   on:click
   on:click="{() => {
     clicked = !clicked;
diff --git a/src/UIShell/GlobalHeader/HeaderActionLink.svelte b/src/UIShell/GlobalHeader/HeaderActionLink.svelte
index c44233cb..59ad3cd9 100644
--- a/src/UIShell/GlobalHeader/HeaderActionLink.svelte
+++ b/src/UIShell/GlobalHeader/HeaderActionLink.svelte
@@ -41,8 +41,9 @@
   class:bx--header__action="{true}"
   class:bx--header__action--active="{linkIsActive}"
   class:action-link="{true}"
-  {...$$restProps}
   href="{href}"
+  rel="{$$restProps.target === '_blank' ? 'noopener noreferrer' : undefined}"
+  {...$$restProps}
 >
   <Icon {...icon} />
 </a>
diff --git a/src/UIShell/GlobalHeader/HeaderPanelLink.svelte b/src/UIShell/GlobalHeader/HeaderPanelLink.svelte
index e5138cd9..745d345a 100644
--- a/src/UIShell/GlobalHeader/HeaderPanelLink.svelte
+++ b/src/UIShell/GlobalHeader/HeaderPanelLink.svelte
@@ -16,6 +16,7 @@
   <a
     bind:this="{ref}"
     href="{href}"
+    rel="{$$restProps.target === '_blank' ? 'noopener noreferrer' : undefined}"
     class:bx--switcher__item-link="{true}"
     {...$$restProps}
     on:click
diff --git a/src/UIShell/SideNav/SideNavLink.svelte b/src/UIShell/SideNav/SideNavLink.svelte
index d05aa9ce..2443af4b 100644
--- a/src/UIShell/SideNav/SideNavLink.svelte
+++ b/src/UIShell/SideNav/SideNavLink.svelte
@@ -37,6 +37,7 @@
     bind:this="{ref}"
     aria-current="{isSelected ? 'page' : undefined}"
     href="{href}"
+    rel="{$$restProps.target === '_blank' ? 'noopener noreferrer' : undefined}"
     class:bx--side-nav__link="{true}"
     class:bx--side-nav__link--current="{isSelected}"
     {...$$restProps}