From 382b2f6e85f7eeb8694f684a5d93980e0a77777e Mon Sep 17 00:00:00 2001 From: Eric Liu Date: Tue, 28 Jul 2020 18:54:18 -0700 Subject: [PATCH] chore(combo-box): remove unnecessary selectedId assignments selectedId is set based on the selectedIndex --- src/ComboBox/ComboBox.svelte | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/ComboBox/ComboBox.svelte b/src/ComboBox/ComboBox.svelte index fa847189..b6737180 100644 --- a/src/ComboBox/ComboBox.svelte +++ b/src/ComboBox/ComboBox.svelte @@ -233,7 +233,6 @@ open = !open; if (highlightedIndex > -1 && highlightedIndex !== selectedIndex) { selectedIndex = highlightedIndex; - selectedId = items[selectedIndex].id; open = false; } } else if (key === 'Tab') { @@ -287,7 +286,6 @@ active={selectedIndex === i || selectedId === item.id} highlighted={highlightedIndex === i || selectedIndex === i} on:click={() => { - selectedId = item.id; selectedIndex = items .map(({ id }) => id) .indexOf(filteredItems[i].id);