mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-18 19:46:36 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix(number-input): use add, subtract icons and update markup

Browse source
This commit is contained in:
Eric Y Liu 2021-03-19 05:28:40 -07:00
commit 3dfb391a73
1 changed files with 22 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

44
src/NumberInput/NumberInput.svelte
View file

@ -101,8 +101,8 @@
export let ref = null; export let ref = null;
import { createEventDispatcher, afterUpdate } from "svelte"; import { createEventDispatcher, afterUpdate } from "svelte";
import CaretDownGlyph from "carbon-icons-svelte/lib/CaretDownGlyph/CaretDownGlyph.svelte"; import Add16 from "carbon-icons-svelte/lib/Add16/Add16.svelte";
import CaretUpGlyph from "carbon-icons-svelte/lib/CaretUpGlyph/CaretUpGlyph.svelte"; import Subtract16 from "carbon-icons-svelte/lib/Subtract16/Subtract16.svelte";
import WarningFilled16 from "carbon-icons-svelte/lib/WarningFilled16/WarningFilled16.svelte"; import WarningFilled16 from "carbon-icons-svelte/lib/WarningFilled16/WarningFilled16.svelte";
import WarningAltFilled16 from "carbon-icons-svelte/lib/WarningAltFilled16/WarningAltFilled16.svelte"; import WarningAltFilled16 from "carbon-icons-svelte/lib/WarningAltFilled16/WarningAltFilled16.svelte";
@ -187,7 +187,7 @@
}}" }}"
disabled="{disabled}" disabled="{disabled}"
> >
<CaretDownGlyph class="down-icon" /> <Subtract16 class="down-icon" />
</button> </button>
<input <input
bind:this="{ref}" bind:this="{ref}"
@ -221,7 +221,7 @@
}}" }}"
disabled="{disabled}" disabled="{disabled}"
> >
<CaretUpGlyph class="up-icon" /> <Add16 class="up-icon" />
</button> </button>
</div> </div>
{:else} {:else}
@ -271,23 +271,7 @@
<div class:bx--number__controls="{true}"> <div class:bx--number__controls="{true}">
<button <button
type="button" type="button"
aria-live="polite" tabindex="-1"
aria-atomic="true"
title="{incrementLabel || iconDescription}"
aria-label="{incrementLabel || iconDescription}"
class:bx--number__control-btn="{true}"
class:up-icon="{true}"
on:click="{() => {
updateValue(1);
}}"
disabled="{disabled}"
>
<CaretUpGlyph class="up-icon" />
</button>
<button
type="button"
aria-live="polite"
aria-atomic="true"
title="{decrementLabel || iconDescription}" title="{decrementLabel || iconDescription}"
aria-label="{decrementLabel || iconDescription}" aria-label="{decrementLabel || iconDescription}"
class:bx--number__control-btn="{true}" class:bx--number__control-btn="{true}"
@ -297,8 +281,24 @@
}}" }}"
disabled="{disabled}" disabled="{disabled}"
> >
<CaretDownGlyph class="down-icon" /> <Subtract16 class="down-icon" />
</button> </button>
<div class:bx--number__rule-divider="{true}"></div>
<button
type="button"
tabindex="-1"
title="{incrementLabel || iconDescription}"
aria-label="{incrementLabel || iconDescription}"
class:bx--number__control-btn="{true}"
class:up-icon="{true}"
on:click="{() => {
updateValue(1);
}}"
disabled="{disabled}"
>
<Add16 class="up-icon" />
</button>
<div class:bx--number__rule-divider="{true}"></div>
</div> </div>
</div> </div>
{/if} {/if}