From 31310199995e4bca941f4c7f10d8769b571f6ae4 Mon Sep 17 00:00:00 2001 From: josefaidt Date: Wed, 16 Sep 2020 14:28:48 -0500 Subject: [PATCH 1/4] fix(tile): add href prop --- src/Tile/ClickableTile.svelte | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/Tile/ClickableTile.svelte b/src/Tile/ClickableTile.svelte index 3ce1997a..07713391 100644 --- a/src/Tile/ClickableTile.svelte +++ b/src/Tile/ClickableTile.svelte @@ -10,6 +10,12 @@ * @type {boolean} [light=false] */ export let light = false; + + /** + * Set the `href` + * @type {string} [href] + */ + export let href = undefined; @@ -19,6 +25,7 @@ class:bx--tile--is-clicked="{clicked}" class:bx--tile--light="{light}" {...$$restProps} + href="{href}" on:click on:click="{() => { clicked = !clicked; From 6567a68a5458eafb0c7c15ee4637e17f78229a47 Mon Sep 17 00:00:00 2001 From: Eric Liu Date: Wed, 16 Sep 2020 12:41:42 -0700 Subject: [PATCH 2/4] v0.12.3 --- CHANGELOG.md | 6 ++++++ COMPONENT_INDEX.md | 1 + types/index.d.ts | 5 +++++ 3 files changed, 12 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index fec9882a..4582381d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Selectable/expandable `DataTable` +## [0.12.3](https://github.com/IBM/carbon-components-svelte/releases/tag/v0.12.3) - 2020-09-16 + +**Fixes** + +- ClickableTile: add missing `href` ([PR #254](https://github.com/IBM/carbon-components-svelte/pull/254), thanks [@josefaidt](https://github.com/josefaidt)) + ## [0.12.2](https://github.com/IBM/carbon-components-svelte/releases/tag/v0.12.2) - 2020-09-14 **Fixes** diff --git a/COMPONENT_INDEX.md b/COMPONENT_INDEX.md index 040aca01..9d44ad04 100644 --- a/COMPONENT_INDEX.md +++ b/COMPONENT_INDEX.md @@ -566,6 +566,7 @@ import { ClickableTile } from "carbon-components-svelte"; | :-------- | :------------------- | :------------ | | clicked | boolean | false | | light | boolean | false | +| href | string | -- | ### Slots diff --git a/types/index.d.ts b/types/index.d.ts index 0a84ed43..e21a2e77 100644 --- a/types/index.d.ts +++ b/types/index.d.ts @@ -317,6 +317,11 @@ export class ClickableTile extends CarbonSvelteComponent { * @default false */ light?: boolean; + + /** + * Set the `href` + */ + href?: string; }; $$slot_def: { default: {} }; From 894a1451c51d9ceb100d6e4f5ea0fe55413af788 Mon Sep 17 00:00:00 2001 From: Eric Liu Date: Wed, 16 Sep 2020 12:42:07 -0700 Subject: [PATCH 3/4] Revert "v0.12.3" This reverts commit 6567a68a5458eafb0c7c15ee4637e17f78229a47. --- CHANGELOG.md | 6 ------ COMPONENT_INDEX.md | 1 - types/index.d.ts | 5 ----- 3 files changed, 12 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4582381d..fec9882a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,12 +9,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Selectable/expandable `DataTable` -## [0.12.3](https://github.com/IBM/carbon-components-svelte/releases/tag/v0.12.3) - 2020-09-16 - -**Fixes** - -- ClickableTile: add missing `href` ([PR #254](https://github.com/IBM/carbon-components-svelte/pull/254), thanks [@josefaidt](https://github.com/josefaidt)) - ## [0.12.2](https://github.com/IBM/carbon-components-svelte/releases/tag/v0.12.2) - 2020-09-14 **Fixes** diff --git a/COMPONENT_INDEX.md b/COMPONENT_INDEX.md index 9d44ad04..040aca01 100644 --- a/COMPONENT_INDEX.md +++ b/COMPONENT_INDEX.md @@ -566,7 +566,6 @@ import { ClickableTile } from "carbon-components-svelte"; | :-------- | :------------------- | :------------ | | clicked | boolean | false | | light | boolean | false | -| href | string | -- | ### Slots diff --git a/types/index.d.ts b/types/index.d.ts index e21a2e77..0a84ed43 100644 --- a/types/index.d.ts +++ b/types/index.d.ts @@ -317,11 +317,6 @@ export class ClickableTile extends CarbonSvelteComponent { * @default false */ light?: boolean; - - /** - * Set the `href` - */ - href?: string; }; $$slot_def: { default: {} }; From e197178a9986db5d753de89c9e746052762139d7 Mon Sep 17 00:00:00 2001 From: Eric Liu Date: Wed, 16 Sep 2020 12:43:36 -0700 Subject: [PATCH 4/4] v0.12.3 --- CHANGELOG.md | 6 ++++++ COMPONENT_INDEX.md | 3 ++- package.json | 2 +- types/index.d.ts | 7 ++++++- 4 files changed, 15 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fec9882a..4582381d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Selectable/expandable `DataTable` +## [0.12.3](https://github.com/IBM/carbon-components-svelte/releases/tag/v0.12.3) - 2020-09-16 + +**Fixes** + +- ClickableTile: add missing `href` ([PR #254](https://github.com/IBM/carbon-components-svelte/pull/254), thanks [@josefaidt](https://github.com/josefaidt)) + ## [0.12.2](https://github.com/IBM/carbon-components-svelte/releases/tag/v0.12.2) - 2020-09-14 **Fixes** diff --git a/COMPONENT_INDEX.md b/COMPONENT_INDEX.md index 040aca01..3607dbe4 100644 --- a/COMPONENT_INDEX.md +++ b/COMPONENT_INDEX.md @@ -1,6 +1,6 @@ # Component Index -> 144 components exported from carbon-components-svelte 0.12.2 +> 144 components exported from carbon-components-svelte 0.12.3 - Accordion - [AccordionSkeleton](#accordionskeleton) @@ -566,6 +566,7 @@ import { ClickableTile } from "carbon-components-svelte"; | :-------- | :------------------- | :------------ | | clicked | boolean | false | | light | boolean | false | +| href | string | -- | ### Slots diff --git a/package.json b/package.json index 0e682431..aae37fca 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "carbon-components-svelte", - "version": "0.12.2", + "version": "0.12.3", "license": "Apache-2.0", "description": "Svelte implementation of the Carbon Design System", "svelte": "./src/index.js", diff --git a/types/index.d.ts b/types/index.d.ts index 0a84ed43..a49092b7 100644 --- a/types/index.d.ts +++ b/types/index.d.ts @@ -1,4 +1,4 @@ -// Type definitions for carbon-components-svelte 0.12.2 +// Type definitions for carbon-components-svelte 0.12.3 // Project: https://github.com/IBM/carbon-components-svelte export class CarbonSvelteComponent { @@ -317,6 +317,11 @@ export class ClickableTile extends CarbonSvelteComponent { * @default false */ light?: boolean; + + /** + * Set the `href` + */ + href?: string; }; $$slot_def: { default: {} };