mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-15 10:21:05 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix(number-input): value 0 should not be converted to null (#1046)

Browse source
This commit is contained in:
metonym 2022-01-27 08:00:32 -08:00 • committed by GitHub
commit 402de56029
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

26
docs/src/pages/components/NumberInput.svx
View file

@ -9,11 +9,15 @@ components: ["NumberInput", "NumberInputSkeleton"]
### Default
<NumberInput label="Clusters" />
This component requires a numerical value for `value`.
See [#no-value](#no-value) to allow for an empty value.
<NumberInput label="Clusters" value={0} />
### With helper text
<NumberInput label="Clusters" helperText="Clusters provisioned in your region" />
<NumberInput label="Clusters" value={0} helperText="Clusters provisioned in your region" />
### Minimum and maximum values
@ -29,39 +33,39 @@ Set `value` to `null` to denote "no value."
### Hidden label
<NumberInput hideLabel label="Clusters" />
<NumberInput hideLabel label="Clusters" value={0} />
### Hidden steppers
<NumberInput hideSteppers label="Clusters" />
<NumberInput hideSteppers label="Clusters" value={0} />
### Light variant
<NumberInput light label="Clusters" />
<NumberInput light label="Clusters" value={0} />
### Read-only variant
<NumberInput readonly label="Clusters" />
<NumberInput readonly label="Clusters" value={0} />
### Extra-large size
<NumberInput size="xl" label="Clusters" />
<NumberInput size="xl" label="Clusters" value={0} />
### Small size
<NumberInput size="sm" label="Clusters" />
<NumberInput size="sm" label="Clusters" value={0} />
### Invalid state
<NumberInput invalid invalidText="Invalid value" label="Clusters" />
<NumberInput invalid invalidText="Invalid value" label="Clusters" value={0} />
### Warning state
<NumberInput warn warnText="A high number may impact initial rollout" label="Clusters" value="25" />
<NumberInput warn warnText="A high number may impact initial rollout" label="Clusters" value={25} />
### Disabled state
<NumberInput disabled label="Clusters" />
<NumberInput disabled label="Clusters" value={0} />
### Skeleton

2
src/NumberInput/NumberInput.svelte
View file

@ -135,7 +135,7 @@
$: dispatch("change", value);
$: incrementLabel = translateWithId("increment");
$: decrementLabel = translateWithId("decrement");
$: value = inputValue ? Number(inputValue) : null;
$: value = inputValue != null ? Number(inputValue) : null;
$: error =
invalid || (!allowEmpty && value == null) || value > max || value < min;
$: errorId = `error-${id}`;