From 45c272642f020b6cfe1adc1a103f7a4bdfa69bf8 Mon Sep 17 00:00:00 2001 From: metonym Date: Sat, 9 Apr 2022 11:24:25 -0700 Subject: [PATCH] fix(link): `$$restProps` should extend `p`, `a` HTML attributes (#1233) * fix(link): restProps should extend `p` or `a` tag attributes * Run "yarn build:docs" * test(link): assert anchor link rest attributes --- docs/src/COMPONENT_API.json | 2 +- src/Link/Link.svelte | 2 ++ tests/Link.test.svelte | 26 +++----------------------- types/Link/Link.svelte.d.ts | 3 ++- 4 files changed, 8 insertions(+), 25 deletions(-) diff --git a/docs/src/COMPONENT_API.json b/docs/src/COMPONENT_API.json index 57d3a1e4..5f21649b 100644 --- a/docs/src/COMPONENT_API.json +++ b/docs/src/COMPONENT_API.json @@ -5347,7 +5347,7 @@ { "type": "forwarded", "name": "mouseleave", "element": "p" } ], "typedefs": [], - "rest_props": { "type": "Element", "name": "p" } + "rest_props": { "type": "Element", "name": "p | a" } }, { "moduleName": "ListBox", diff --git a/src/Link/Link.svelte b/src/Link/Link.svelte index 65732cc4..7073d97b 100644 --- a/src/Link/Link.svelte +++ b/src/Link/Link.svelte @@ -1,4 +1,6 @@ -Carbon Design System - - + Carbon Design System - - Carbon Design System - - - - Carbon Design System - - - - Carbon Design System - - - - Carbon Design System - - - - Carbon Design System - + diff --git a/types/Link/Link.svelte.d.ts b/types/Link/Link.svelte.d.ts index c933c46c..c1054041 100644 --- a/types/Link/Link.svelte.d.ts +++ b/types/Link/Link.svelte.d.ts @@ -2,7 +2,8 @@ import { SvelteComponentTyped } from "svelte"; export interface LinkProps - extends svelte.JSX.HTMLAttributes { + extends svelte.JSX.HTMLAttributes, + svelte.JSX.HTMLAttributes { /** * Specify the size of the link * @default undefined