From 45f14f160e40f7eb21e66b5a6937fc7effe06721 Mon Sep 17 00:00:00 2001 From: metonym Date: Fri, 5 Aug 2022 05:21:49 -0700 Subject: [PATCH] refactor: use class directive in `TextInput`, `DatePickerInput` (#1426) Dynamically-formed class names should be avoided for easier static analysis. The Svelte `class:` directive should be used instead. --- src/DatePicker/DatePickerInput.svelte | 3 ++- src/TextInput/TextInput.svelte | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/DatePicker/DatePickerInput.svelte b/src/DatePicker/DatePickerInput.svelte index 0ceebea6..92855bcd 100644 --- a/src/DatePicker/DatePickerInput.svelte +++ b/src/DatePicker/DatePickerInput.svelte @@ -116,7 +116,8 @@ : $inputValue}" class:bx--date-picker__input="{true}" class:bx--date-picker__input--invalid="{invalid}" - class="{size && `bx--date-picker__input--${size}`}" + class:bx--date-picker__input--sm="{size === 'sm'}" + class:bx--date-picker__input--xl="{size === 'xl'}" on:input on:input="{({ target }) => { updateValue({ type: 'input', value: target.value }); diff --git a/src/TextInput/TextInput.svelte b/src/TextInput/TextInput.svelte index 2b149674..2616c2bc 100644 --- a/src/TextInput/TextInput.svelte +++ b/src/TextInput/TextInput.svelte @@ -146,7 +146,8 @@ class:bx--visually-hidden="{hideLabel}" class:bx--label--disabled="{disabled}" class:bx--label--inline="{inline}" - class="{inline && !!size && `bx--label--inline--${size}`}" + class:bx--label--inline-sm="{inline && size === 'sm'}" + class:bx--label--inline-xl="{inline && size === 'xl'}" > {labelText}