mirror of
https://github.com/carbon-design-system/carbon-components-svelte.git
synced 2025-09-18 19:46:36 +00:00
fix: readonly inputs cannot be invalid
Addresses https://github.com/carbon-design-system/carbon-components-svelte/pull/1666#pullrequestreview-1314558645
This commit is contained in:
parent
726f62e5f1
commit
480f932d69
2 changed files with 9 additions and 8 deletions
|
@ -128,7 +128,7 @@
|
|||
$: incrementLabel = translateWithId("increment");
|
||||
$: decrementLabel = translateWithId("decrement");
|
||||
$: error =
|
||||
invalid ||
|
||||
(invalid && !readonly) ||
|
||||
(!allowEmpty && value == null) ||
|
||||
value > max ||
|
||||
(typeof value === "number" && value < min);
|
||||
|
@ -191,8 +191,8 @@
|
|||
type="number"
|
||||
pattern="[0-9]*"
|
||||
aria-describedby="{errorId}"
|
||||
data-invalid="{invalid || undefined}"
|
||||
aria-invalid="{invalid || undefined}"
|
||||
data-invalid="{(error) || undefined}"
|
||||
aria-invalid="{(error) || undefined}"
|
||||
aria-label="{label ? undefined : ariaLabel}"
|
||||
disabled="{disabled}"
|
||||
id="{id}"
|
||||
|
|
|
@ -95,6 +95,7 @@
|
|||
};
|
||||
|
||||
$: isFluid = !!ctx && ctx.isFluid;
|
||||
$: error = invalid && !readonly;
|
||||
$: helperId = `helper-${id}`;
|
||||
$: errorId = `error-${id}`;
|
||||
$: warnId = `warn-${id}`;
|
||||
|
@ -161,7 +162,7 @@
|
|||
class:bx--text-input__field-outer-wrapper--inline="{inline}"
|
||||
>
|
||||
<div
|
||||
data-invalid="{invalid || undefined}"
|
||||
data-invalid="{error || undefined}"
|
||||
data-warn="{warn || undefined}"
|
||||
class:bx--text-input__field-wrapper="{true}"
|
||||
class:bx--text-input__field-wrapper--warning="{!invalid && warn}"
|
||||
|
@ -181,10 +182,10 @@
|
|||
{/if}
|
||||
<input
|
||||
bind:this="{ref}"
|
||||
data-invalid="{invalid || undefined}"
|
||||
aria-invalid="{invalid || undefined}"
|
||||
data-invalid="{error || undefined}"
|
||||
aria-invalid="{error || undefined}"
|
||||
data-warn="{warn || undefined}"
|
||||
aria-describedby="{invalid
|
||||
aria-describedby="{error
|
||||
? errorId
|
||||
: warn
|
||||
? warnId
|
||||
|
@ -200,7 +201,7 @@
|
|||
readonly="{readonly}"
|
||||
class:bx--text-input="{true}"
|
||||
class:bx--text-input--light="{light}"
|
||||
class:bx--text-input--invalid="{invalid}"
|
||||
class:bx--text-input--invalid="{error}"
|
||||
class:bx--text-input--warn="{warn}"
|
||||
class:bx--text-input--sm="{size === 'sm'}"
|
||||
class:bx--text-input--xl="{size === 'xl'}"
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue