mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-15 18:31:06 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #402 from IBM/button-icon-svelte

Browse source 
refactor(button): remove redundant if statement
This commit is contained in:
Eric Liu 2020-11-20 09:22:44 -08:00 • committed by GitHub
commit 4ad9ff3ef5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

28
src/Button/Button.svelte
View file

@ -135,14 +135,12 @@
<span class:bx--assistive-text="{true}">{iconDescription}</span> <span class:bx--assistive-text="{true}">{iconDescription}</span>
{/if} {/if}
<slot /> <slot />
{#if icon} <svelte:component
<svelte:component this="{icon}"
this="{icon}" aria-hidden="true"
aria-hidden="true" class="bx--btn__icon"
class="bx--btn__icon" aria-label="{iconDescription}"
aria-label="{iconDescription}" />
/>
{/if}
</a> </a>
{:else} {:else}
<button <button
@ -157,14 +155,12 @@
<span class:bx--assistive-text="{true}">{iconDescription}</span> <span class:bx--assistive-text="{true}">{iconDescription}</span>
{/if} {/if}
<slot /> <slot />
{#if icon} <svelte:component
<svelte:component this="{icon}"
this="{icon}" aria-hidden="true"
aria-hidden="true" class="bx--btn__icon"
class="bx--btn__icon" aria-label="{iconDescription}"
aria-label="{iconDescription}" />
/>
{/if}
</button> </button>
{/if} {/if}
{/if} {/if}