From 4be4c498b6efd4fc2c6b7e7a9c7dee105a543ee1 Mon Sep 17 00:00:00 2001 From: Eric Liu Date: Mon, 28 Sep 2020 14:10:30 -0700 Subject: [PATCH] fix(slider): dont update slider if disabled --- src/Slider/Slider.Story.svelte | 2 +- src/Slider/Slider.svelte | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Slider/Slider.Story.svelte b/src/Slider/Slider.Story.svelte index ecb00a0b..9ca44e8e 100644 --- a/src/Slider/Slider.Story.svelte +++ b/src/Slider/Slider.Story.svelte @@ -4,7 +4,7 @@ import Slider from "./Slider.svelte"; import SliderSkeleton from "./Slider.Skeleton.svelte"; - $: value = 50; + let value = 50; {#if story === 'skeleton'} diff --git a/src/Slider/Slider.svelte b/src/Slider/Slider.svelte index af658e5f..6507704d 100644 --- a/src/Slider/Slider.svelte +++ b/src/Slider/Slider.svelte @@ -129,6 +129,8 @@ } function calcValue(e) { + if (disabled) return; + const offsetX = e.touches ? e.touches[0].clientX : e.clientX; const { left, width } = trackRef.getBoundingClientRect(); let nextValue = @@ -158,7 +160,7 @@ dragging = false; } - if (!holding) { + if (!holding && !disabled) { dispatch("change", value); } }