From 4f83b2d1e1bbc05ca711889a1469f9fa097fe4d6 Mon Sep 17 00:00:00 2001 From: Eric Liu Date: Fri, 19 Nov 2021 08:29:16 -0800 Subject: [PATCH] fix(data-table): forgo "click", "click:row" events if target is an OverflowMenu (#918) #917 --- src/DataTable/DataTable.svelte | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/DataTable/DataTable.svelte b/src/DataTable/DataTable.svelte index 8acdf8af..e6d5b256 100644 --- a/src/DataTable/DataTable.svelte +++ b/src/DataTable/DataTable.svelte @@ -336,7 +336,15 @@ : ''} {expandable && parentRowId === row.id ? 'bx--expandable-row--hover' : ''}" - on:click="{() => { + on:click="{({ target }) => { + // forgo "click", "click:row" events if target resembles an overflow menu + if ( + [...target.classList].some((name) => + /^bx--overflow-menu/.test(name) + ) + ) { + return; + } dispatch('click', { row }); dispatch('click:row', row); }}"