mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-14 18:01:06 +00:00
Code Issues Projects Releases Packages Wiki Activity

feat(notification)!: replace iconDescription prop with statusIconDescription, closeButtonDescription (#1591)

Browse source 
Fixes #672, fixes #1563

* breaking: remove `iconDescription` prop from `InlineNotification`, `ToastNotification`

* breaking: require `iconDescription` prop in `NotificationIcon`

* feat: add new `statusIconDescription` and `closeButtonDescription` to `InlineNotification`, `ToastNotification`
This commit is contained in:
Enrico Sacchetti 2022-12-18 18:28:23 -05:00 • committed by GitHub
commit 50066966da
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
10 changed files with 144 additions and 53 deletions
Download patch file Download diff file Expand all files Collapse all files

12
types/Notification/InlineNotification.svelte.d.ts vendored
View file

@ -52,10 +52,16 @@ export interface InlineNotificationProps
hideCloseButton?: boolean;
/**
* Specify the ARIA label for the icon
* @default "Closes notification"
* Specify the ARIA label for the status icon
* @default kind + " icon"
*/
iconDescription?: string;
statusIconDescription?: string;
/**
* Specify the ARIA label for the close button
* @default "Close notification"
*/
closeButtonDescription?: string;
}
export default class InlineNotification extends SvelteComponentTyped<

4
types/Notification/NotificationIcon.svelte.d.ts vendored
View file

@ -22,9 +22,9 @@ export interface NotificationIconProps {
/**
* Specify the ARIA label for the icon
* @default "Closes notification"
* @default undefined
*/
iconDescription?: string;
iconDescription: undefined;
}
export default class NotificationIcon extends SvelteComponentTyped<

12
types/Notification/ToastNotification.svelte.d.ts vendored
View file

@ -52,10 +52,16 @@ export interface ToastNotificationProps
caption?: string;
/**
* Specify the ARIA label for the icon
* @default "Closes notification"
* Specify the ARIA label for the status icon
* @default kind + " icon"
*/
iconDescription?: string;
statusIconDescription?: string;
/**
* Specify the ARIA label for the close button
* @default "Close notification"
*/
closeButtonDescription?: string;
/**
* Set to `true` to hide the close button