mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-15 02:11:05 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix a11y warnings emitted by Svelte v3.45 (#989)

Browse source 
* chore(deps-dev): bump svelte to version 3.45

* fix: resolve a11y violations

Fixes #988
This commit is contained in:
Eric Liu 2022-01-10 11:57:52 -10:00 • committed by GitHub
commit 502f9379fa
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
package.json
View file

@ -42,7 +42,7 @@
"rollup-plugin-terser": "^7.0.2", "rollup-plugin-terser": "^7.0.2",
"sass": "^1.42.1", "sass": "^1.42.1",
"sveld": "^0.11.1", "sveld": "^0.11.1",
"svelte": "^3.44.3", "svelte": "^3.45.0",
"svelte-check": "^1.1.32", "svelte-check": "^1.1.32",
"typescript": "^4.1.3" "typescript": "^4.1.3"
}, },

1
src/Dropdown/Dropdown.svelte
View file

@ -198,7 +198,6 @@
bind:this="{ref}" bind:this="{ref}"
class:bx--list-box__field="{true}" class:bx--list-box__field="{true}"
tabindex="0" tabindex="0"
role="button"
aria-expanded="{open}" aria-expanded="{open}"
on:keydown="{(e) => { on:keydown="{(e) => {
const { key } = e; const { key } = e;

2
src/UIShell/GlobalHeader/Header.svelte
View file

@ -78,7 +78,7 @@
<svelte:window bind:innerWidth="{winWidth}" /> <svelte:window bind:innerWidth="{winWidth}" />
<header role="banner" aria-label="{ariaLabel}" class:bx--header="{true}"> <header aria-label="{ariaLabel}" class:bx--header="{true}">
<slot name="skip-to-content" /> <slot name="skip-to-content" />
{#if ($shouldRenderHamburgerMenu && winWidth < expansionBreakpoint) || persistentHamburgerMenu} {#if ($shouldRenderHamburgerMenu && winWidth < expansionBreakpoint) || persistentHamburgerMenu}
<HamburgerMenu <HamburgerMenu

8
yarn.lock
View file

@ -2350,10 +2350,10 @@ svelte@^3.42.4:
resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.43.2.tgz#217fc6059f52afa281f39200b6253ac1b83812b4" resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.43.2.tgz#217fc6059f52afa281f39200b6253ac1b83812b4"
integrity sha512-Lj+TJfSeod8UGnoG2opysdlCy4MCck/hHQsZwtNPXdYTwLTz+WC37QwewPhZtd+h3dpfps4h9QzFxWGVI4tzQw== integrity sha512-Lj+TJfSeod8UGnoG2opysdlCy4MCck/hHQsZwtNPXdYTwLTz+WC37QwewPhZtd+h3dpfps4h9QzFxWGVI4tzQw==
svelte@^3.44.3: svelte@^3.45.0:
version "3.44.3" version "3.45.0"
resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.44.3.tgz#795b1ced6ed3da44969099e5061b850c93c95e9a" resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.45.0.tgz#bcb90a72e984f809c419529f8cf9100ad9937a4b"
integrity sha512-aGgrNCip5PQFNfq9e9tmm7EYxWLVHoFsEsmKrtOeRD8dmoGDdyTQ+21xd7qgFd8MNdKGSYvg7F9dr+Tc0yDymg== integrity sha512-6AWftH2eqqKLYH1HvKpuUWe8OfjflarhegN57P/Cqwc2Rb2F5oIdDtANU/jMscyZMzG0v6nTQox0siZR9cmRVQ==
terser@^5.0.0: terser@^5.0.0:
version "5.3.0" version "5.3.0"