From 566a281d8197413378b9e95d4627946b58c5d8cc Mon Sep 17 00:00:00 2001
From: Eric Liu <ericyl.us@gmail.com>
Date: Sun, 26 Jul 2020 15:12:28 -0700
Subject: [PATCH] chore(ui-shell): remove ambiguous type prop in favor of
 $$restProps

---
 src/UIShell/GlobalHeader/HeaderAction.svelte  | 19 ++++++++++++++++---
 .../GlobalHeader/HeaderActionLink.svelte      | 19 ++++++++++++++++---
 2 files changed, 32 insertions(+), 6 deletions(-)

diff --git a/src/UIShell/GlobalHeader/HeaderAction.svelte b/src/UIShell/GlobalHeader/HeaderAction.svelte
index 9e6a6753..6d6f5d1e 100644
--- a/src/UIShell/GlobalHeader/HeaderAction.svelte
+++ b/src/UIShell/GlobalHeader/HeaderAction.svelte
@@ -1,7 +1,21 @@
 <script>
-  export let type = undefined;
+  /**
+   * Set to `true` to open the panel
+   * @type {boolean} [isOpen=false]
+   */
+  export let isOpen = false;
+
+  /**
+   * Specify the icon props
+   * @type {{ render: typeof import("carbon-icons-svelte/lib/Add16").default; skeleton: boolean; }} [icon]
+   */
   export let icon = undefined;
-  export let isOpen = undefined;
+
+  /**
+   * Specify the text
+   * Alternatively, use the named slot "text" (e.g. <div slot="text">...</div>)
+   * @type {string} [text]
+   */
   export let text = undefined;
 
   import { Icon } from "../../Icon";
@@ -38,7 +52,6 @@
 <div>
   <button
     type="button"
-    aria-label={type}
     class:bx--header__action={true}
     class:bx--header__action--active={isOpen}
     class:action-text={text}
diff --git a/src/UIShell/GlobalHeader/HeaderActionLink.svelte b/src/UIShell/GlobalHeader/HeaderActionLink.svelte
index b03c4f3e..29813315 100644
--- a/src/UIShell/GlobalHeader/HeaderActionLink.svelte
+++ b/src/UIShell/GlobalHeader/HeaderActionLink.svelte
@@ -1,8 +1,21 @@
 <script>
+  /**
+   * Set to `true` to use the active state
+   * @type {boolean} [linkIsActive=false]
+   */
+  export let linkIsActive = false;
+
+  /**
+   * Specify the `href` attribute
+   * @type {string} [href]
+   */
   export let href = undefined;
-  export let type = undefined;
+
+  /**
+   * Specify the icon props
+   * @type {{ render: typeof import("carbon-icons-svelte/lib/Add16").default; skeleton: boolean; }} [icon]
+   */
   export let icon = undefined;
-  export let linkIsActive = undefined;
 
   import { Icon } from "../../Icon";
 </script>
@@ -18,10 +31,10 @@
 </style>
 
 <a
-  aria-label={type}
   class:bx--header__action={true}
   class:bx--header__action--active={linkIsActive}
   class:action-link={true}
+  {...$$restProps}
   {href}>
   <Icon {...icon} />
 </a>