From b63e62e6f1e95f1a9553d77540446ca290ccbf34 Mon Sep 17 00:00:00 2001 From: Eric Liu Date: Sun, 15 Dec 2019 15:30:56 -0800 Subject: [PATCH 1/2] refactor(text-area): update bound value on input --- src/components/TextArea/TextArea.svelte | 48 +++++++++++-------------- 1 file changed, 20 insertions(+), 28 deletions(-) diff --git a/src/components/TextArea/TextArea.svelte b/src/components/TextArea/TextArea.svelte index 2bbb1ab8..99a66b10 100644 --- a/src/components/TextArea/TextArea.svelte +++ b/src/components/TextArea/TextArea.svelte @@ -4,13 +4,13 @@ export let cols = 50; export let disabled = false; export let id = Math.random(); - export let labelText = undefined; + export let labelText = ''; export let placeholder = ''; export let rows = 4; - export let value = undefined; + export let value = ''; export let invalid = false; - export let invalidText = undefined; - export let helperText = undefined; + export let invalidText = ''; + export let helperText = ''; export let hideLabel = false; export let light = false; export let props = {}; @@ -33,24 +33,6 @@ invalid && '--text-area--invalid', className ); - - function handleClick(event) { - if (!disabled) { - dispatch('click', event); - } - } - - function handleChange(event) { - if (!disabled) { - dispatch('change', event); - } - } - - function handleInput(event) { - if (!disabled) { - dispatch('input', event); - } - }
@@ -66,12 +48,22 @@ {/if}