From 5e8915df7fcfee9bce81c95420c98369313c2351 Mon Sep 17 00:00:00 2001 From: Eric Liu Date: Mon, 28 Sep 2020 14:08:24 -0700 Subject: [PATCH] fix(slider): dispatch change event in reactive statement Removes afterUpdate method --- src/Slider/Slider.svelte | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/Slider/Slider.svelte b/src/Slider/Slider.svelte index 4069ff97..af658e5f 100644 --- a/src/Slider/Slider.svelte +++ b/src/Slider/Slider.svelte @@ -101,7 +101,7 @@ */ export let ref = null; - import { createEventDispatcher, afterUpdate } from "svelte"; + import { createEventDispatcher } from "svelte"; const dispatch = createEventDispatcher(); @@ -144,12 +144,6 @@ value = nextValue; } - afterUpdate(() => { - if (!holding) { - dispatch("change", value); - } - }); - $: range = max - min; $: left = ((value - min) / range) * 100; $: { @@ -163,6 +157,10 @@ calcValue(event); dragging = false; } + + if (!holding) { + dispatch("change", value); + } }