From 636e89cb1ef66e8e0180af80de89df3676d90005 Mon Sep 17 00:00:00 2001 From: Eric Liu Date: Wed, 16 Feb 2022 07:26:05 -0800 Subject: [PATCH] fix(multi-select): pressing Enter should toggle menu, Space should select item --- src/MultiSelect/MultiSelect.svelte | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/MultiSelect/MultiSelect.svelte b/src/MultiSelect/MultiSelect.svelte index c3434432..d49fc526 100644 --- a/src/MultiSelect/MultiSelect.svelte +++ b/src/MultiSelect/MultiSelect.svelte @@ -326,8 +326,15 @@ e.preventDefault(); } - if (key === ' ') { - open = !open; + if (key === ' ' || key === 'Enter') { + if (highlightedIndex > -1) { + sortedItems = sortedItems.map((item, i) => { + if (i !== highlightedIndex) return item; + return { ...item, checked: !item.checked }; + }); + } else { + open = !open; + } } else if (key === 'Tab') { if (selectionRef && checked.length > 0) { selectionRef.focus(); @@ -339,13 +346,6 @@ change(1); } else if (key === 'ArrowUp') { change(-1); - } else if (key === 'Enter') { - if (highlightedIndex > -1) { - sortedItems = sortedItems.map((item, i) => { - if (i !== highlightedIndex) return item; - return { ...item, checked: !item.checked }; - }); - } } else if (key === 'Escape') { open = false; }