From 6450e8b0b17e1538043f131d64e2d1fc667c95a8 Mon Sep 17 00:00:00 2001 From: metonym Date: Sat, 11 Feb 2023 10:50:01 -0800 Subject: [PATCH] fix(types): add missing `$$restProps` for `Checkbox`, `Filename`, `FluidForm` (#1655) * fix(types): add missing `$$restProps` for `Checkbox`, `Filename`, `FluidForm` * Run "yarn build:docs" * test: assert `$$restProps` for `Checkbox`, `Form` --- docs/src/COMPONENT_API.json | 6 +++--- src/Checkbox/Checkbox.svelte | 1 + src/FileUploader/Filename.svelte | 4 ++++ src/FluidForm/FluidForm.svelte | 4 ++++ tests/Checkbox.test.svelte | 2 +- tests/FluidForm.test.svelte | 2 +- types/Checkbox/Checkbox.svelte.d.ts | 3 ++- types/FileUploader/Filename.svelte.d.ts | 5 ++++- types/FluidForm/FluidForm.svelte.d.ts | 3 ++- 9 files changed, 22 insertions(+), 8 deletions(-) diff --git a/docs/src/COMPONENT_API.json b/docs/src/COMPONENT_API.json index dd56f7cc..9019526b 100644 --- a/docs/src/COMPONENT_API.json +++ b/docs/src/COMPONENT_API.json @@ -924,7 +924,7 @@ { "type": "forwarded", "name": "blur", "element": "input" } ], "typedefs": [], - "rest_props": { "type": "InlineComponent", "name": "CheckboxSkeleton" } + "rest_props": { "type": "Element", "name": "div" } }, { "moduleName": "CheckboxSkeleton", @@ -4399,7 +4399,7 @@ { "type": "forwarded", "name": "keydown", "element": "button" } ], "typedefs": [], - "rest_props": { "type": "InlineComponent", "name": "Loading" } + "rest_props": { "type": "Element", "name": "div | button | svg" } }, { "moduleName": "FluidForm", @@ -4416,7 +4416,7 @@ { "type": "forwarded", "name": "submit", "element": "Form" } ], "typedefs": [], - "rest_props": { "type": "InlineComponent", "name": "Form" } + "rest_props": { "type": "Element", "name": "form" } }, { "moduleName": "Form", diff --git a/src/Checkbox/Checkbox.svelte b/src/Checkbox/Checkbox.svelte index a98efe29..775aa344 100644 --- a/src/Checkbox/Checkbox.svelte +++ b/src/Checkbox/Checkbox.svelte @@ -1,5 +1,6 @@ - + diff --git a/tests/FluidForm.test.svelte b/tests/FluidForm.test.svelte index f1c17dce..8f39452b 100644 --- a/tests/FluidForm.test.svelte +++ b/tests/FluidForm.test.svelte @@ -2,7 +2,7 @@ import { FluidForm, TextInput, PasswordInput } from "../types"; - + import type { SvelteComponentTyped } from "svelte"; -export interface CheckboxProps { +export interface CheckboxProps + extends svelte.JSX.HTMLAttributes { /** * Specify the value of the checkbox * @default "" diff --git a/types/FileUploader/Filename.svelte.d.ts b/types/FileUploader/Filename.svelte.d.ts index af4bfd4c..7600bfc7 100644 --- a/types/FileUploader/Filename.svelte.d.ts +++ b/types/FileUploader/Filename.svelte.d.ts @@ -1,7 +1,10 @@ /// import type { SvelteComponentTyped } from "svelte"; -export interface FilenameProps { +export interface FilenameProps + extends svelte.JSX.HTMLAttributes, + svelte.JSX.HTMLAttributes, + svelte.JSX.SVGAttributes { /** * Specify the file name status * @default "uploading" diff --git a/types/FluidForm/FluidForm.svelte.d.ts b/types/FluidForm/FluidForm.svelte.d.ts index 0474b869..1bc27300 100644 --- a/types/FluidForm/FluidForm.svelte.d.ts +++ b/types/FluidForm/FluidForm.svelte.d.ts @@ -1,7 +1,8 @@ /// import type { SvelteComponentTyped } from "svelte"; -export interface FluidFormProps {} +export interface FluidFormProps + extends svelte.JSX.HTMLAttributes {} export default class FluidForm extends SvelteComponentTyped< FluidFormProps,