From 66c96612bf6129669993695681406d50ce6f7360 Mon Sep 17 00:00:00 2001
From: metonym <ericyl.us@gmail.com>
Date: Wed, 1 Jun 2022 18:55:27 -0700
Subject: [PATCH] fix(dropdown): remove redundant role/id (#1327)

* fix(list-box): list box item should have a role and `aria-selected` attribute

* fix(dropdown): remove redundant role/id
---
 src/Dropdown/Dropdown.svelte       | 2 +-
 src/ListBox/ListBoxMenuItem.svelte | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/Dropdown/Dropdown.svelte b/src/Dropdown/Dropdown.svelte
index 907182d7..2ef0a144 100644
--- a/src/Dropdown/Dropdown.svelte
+++ b/src/Dropdown/Dropdown.svelte
@@ -164,9 +164,9 @@
     </label>
   {/if}
   <ListBox
+    role="{undefined}"
     type="{type}"
     size="{size}"
-    id="{id}"
     name="{name}"
     aria-label="{$$props['aria-label']}"
     class="bx--dropdown {direction === 'top' && 'bx--list-box--up'} {invalid &&
diff --git a/src/ListBox/ListBoxMenuItem.svelte b/src/ListBox/ListBoxMenuItem.svelte
index b71d1b91..9ef1ffb9 100644
--- a/src/ListBox/ListBoxMenuItem.svelte
+++ b/src/ListBox/ListBoxMenuItem.svelte
@@ -12,9 +12,11 @@
 </script>
 
 <div
+  role="option"
   class:bx--list-box__menu-item="{true}"
   class:bx--list-box__menu-item--active="{active}"
   class:bx--list-box__menu-item--highlighted="{highlighted}"
+  aria-selected="{active}"
   {...$$restProps}
   on:click
   on:mouseenter