From 6f9dddbcc01c0590bf887173c174e9976fc999e8 Mon Sep 17 00:00:00 2001 From: Eric Liu Date: Sat, 27 Nov 2021 09:59:30 -0800 Subject: [PATCH] fix(multiselect): do not mutate sortedItems --- src/MultiSelect/MultiSelect.svelte | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/MultiSelect/MultiSelect.svelte b/src/MultiSelect/MultiSelect.svelte index d710faca..56c9036c 100644 --- a/src/MultiSelect/MultiSelect.svelte +++ b/src/MultiSelect/MultiSelect.svelte @@ -329,9 +329,10 @@ change(-1); } else if (key === 'Enter') { if (highlightedIndex > -1) { - sortedItems[highlightedIndex].checked = !sortedItems[ - highlightedIndex - ].checked; + sortedItems = sortedItems.map((item, i) => { + if (i !== highlightedIndex) return item; + return { ...item, checked: !item.checked }; + }); } } }}" @@ -403,9 +404,10 @@ return { ...item, checked: !item.checked }; }); } else { - sortedItems[highlightedIndex].checked = !sortedItems[ - highlightedIndex - ].checked; + sortedItems = sortedItems.map((item, i) => { + if (i !== highlightedIndex) return item; + return { ...item, checked: !item.checked }; + }); } } } else if (key === 'Tab') {