mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-20 20:33:02 +00:00
Code Issues Projects Releases Packages Wiki Activity

Incorprate PR feedback

Browse source
This commit is contained in:
Gregor Wassmann 2021-12-30 20:57:50 +01:00
commit 6fb2fa60e2
1 changed files with 4 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/Checkbox/Checkbox.svelte
View file

@ -57,16 +57,6 @@
const dispatch = createEventDispatcher(); const dispatch = createEventDispatcher();
$: dispatch("check", checked); $: dispatch("check", checked);
$: checked = group.indexOf(value) >= 0;
const updateGroup = () => {
if (checked) {
group = [...group, value];
} else {
group.splice(group.indexOf(value), 1);
group = group;
}
};
</script> </script>
<!-- svelte-ignore a11y-mouse-events-have-key-events --> <!-- svelte-ignore a11y-mouse-events-have-key-events -->
@ -92,7 +82,7 @@
bind:this="{ref}" bind:this="{ref}"
type="checkbox" type="checkbox"
value="{value}" value="{value}"
checked="{checked}" checked="{checked || group.includes(value)}"
disabled="{disabled}" disabled="{disabled}"
id="{id}" id="{id}"
indeterminate="{indeterminate}" indeterminate="{indeterminate}"
@ -102,8 +92,10 @@
on:change on:change
on:change="{() => { on:change="{() => {
checked = !checked; checked = !checked;
group = group.includes(value)
? group.filter((_value) => _value !== value)
: [...group, value];
}}" }}"
on:change="{updateGroup}"
on:blur on:blur
/> />
<label for="{id}" title="{title}" class:bx--checkbox-label="{true}"> <label for="{id}" title="{title}" class:bx--checkbox-label="{true}">