diff --git a/.gitignore b/.gitignore index 3ea1c561..c88ff787 100644 --- a/.gitignore +++ b/.gitignore @@ -6,4 +6,5 @@ yarn-debug.log* yarn-error.log* *.tgz -.vscode \ No newline at end of file +.vscode +.idea/* diff --git a/src/components/ComboBox/ComboBox.stories.js b/src/components/ComboBox/ComboBox.stories.js index acfc0a76..4e6973f4 100644 --- a/src/components/ComboBox/ComboBox.stories.js +++ b/src/components/ComboBox/ComboBox.stories.js @@ -19,6 +19,7 @@ export const Default = () => ({ light: boolean('Light (light)', false), disabled: boolean('Disabled (disabled)', false), invalid: boolean('Invalid (invalid)', false), - invalidText: text('Invalid text (invalidText)', 'A valid value is required') + invalidText: text('Invalid text (invalidText)', 'A valid value is required'), + name: 'combo-box-name' } }); diff --git a/src/components/ComboBox/ComboBox.svelte b/src/components/ComboBox/ComboBox.svelte index f487980b..5134fae8 100644 --- a/src/components/ComboBox/ComboBox.svelte +++ b/src/components/ComboBox/ComboBox.svelte @@ -18,6 +18,7 @@ export let titleText = ''; export let translateWithId = undefined; export let value = ''; + export let name = Math.random(); import { afterUpdate } from 'svelte'; import WarningFilled16 from 'carbon-icons-svelte/lib/WarningFilled16'; @@ -100,6 +101,7 @@ open = true; }} {id} + {name} {disabled} {translateWithId}> ({ }, datePickerInput: { id: 'date-picker-input-id', + name: 'date-picker-input-name', labelText: text('Label text (labelText in )', 'Date Picker label'), hideLabel: boolean('Hide label (hideLabel)', false), pattern: select('The date format (pattern in )', patterns, 'd{1,2}/d{4}'), diff --git a/src/components/DatePicker/DatePickerInput.svelte b/src/components/DatePicker/DatePickerInput.svelte index b575aa06..0b9b1d96 100644 --- a/src/components/DatePicker/DatePickerInput.svelte +++ b/src/components/DatePicker/DatePickerInput.svelte @@ -12,6 +12,7 @@ export let placeholder = ''; export let style = undefined; export let type = 'text'; + export let name = Math.random(); import { getContext, onMount } from 'svelte'; import Calendar16 from 'carbon-icons-svelte/lib/Calendar16'; @@ -71,6 +72,7 @@ blurInput(relatedTarget); }} {id} + {name} {placeholder} {type} {pattern} diff --git a/src/components/Dropdown/Dropdown.stories.js b/src/components/Dropdown/Dropdown.stories.js index 0fe46fd6..efe335b7 100644 --- a/src/components/Dropdown/Dropdown.stories.js +++ b/src/components/Dropdown/Dropdown.stories.js @@ -17,7 +17,8 @@ const sizes = { export const Default = () => ({ Component, props: { - id: text('Dropdown ID (id)', 'carbon-dropdown-example'), + id: text('Dropdown id', 'carbon-dropdown-id'), + name: text('Dropdown name', 'carbon-dropdown-name'), type: select('Dropdown type (type)', types, 'default'), size: select('Field size (size)', sizes, '') || undefined, label: text('Label (label)', 'Dropdown menu options'), diff --git a/src/components/Dropdown/Dropdown.svelte b/src/components/Dropdown/Dropdown.svelte index 53ecb4fa..923e4bb1 100644 --- a/src/components/Dropdown/Dropdown.svelte +++ b/src/components/Dropdown/Dropdown.svelte @@ -4,6 +4,7 @@ export let disabled = false; export let helperText = ''; export let id = Math.random(); + export let name = Math.random(); export let inline = false; export let invalid = false; export let invalidText = ''; @@ -75,6 +76,7 @@ {type} {size} {id} + {name} aria-label={$$props['aria-label']} class={cx('--dropdown', invalid && '--dropdown--invalid', open && '--dropdown--open', inline && '--dropdown--inline', disabled && '--dropdown--disabled', light && '--dropdown--light')} on:click={({ target }) => { diff --git a/src/components/MultiSelect/MultiSelect.Story.svelte b/src/components/MultiSelect/MultiSelect.Story.svelte index d8e42196..e7795678 100644 --- a/src/components/MultiSelect/MultiSelect.Story.svelte +++ b/src/components/MultiSelect/MultiSelect.Story.svelte @@ -32,7 +32,8 @@
({ Component, props: { - id: 'multiselect', + id: text('MultiSelect id', 'multi-select-id'), + name: text('MultiSelect name', 'multi-select-name'), titleText: text('Title (titleText)', 'Multiselect Title'), helperText: text('Helper text (helperText)', 'This is not helper text'), filterable: boolean('Filterable (filterable)', false), diff --git a/src/components/MultiSelect/MultiSelect.svelte b/src/components/MultiSelect/MultiSelect.svelte index 6b825d8b..406a1c70 100644 --- a/src/components/MultiSelect/MultiSelect.svelte +++ b/src/components/MultiSelect/MultiSelect.svelte @@ -6,6 +6,7 @@ export let filterItem = (item, value) => item.text.toLowerCase().includes(value.toLowerCase()); export let helperText = ''; export let id = Math.random(); + export let name = Math.random(); export let invalid = false; export let invalidText = ''; export let items = []; @@ -236,6 +237,7 @@ {disabled} {placeholder} {id} + {name} value={inputValue} /> {#if invalid} diff --git a/src/components/NumberInput/NumberInput.Story.svelte b/src/components/NumberInput/NumberInput.Story.svelte index a5d38473..3acbf769 100644 --- a/src/components/NumberInput/NumberInput.Story.svelte +++ b/src/components/NumberInput/NumberInput.Story.svelte @@ -14,7 +14,8 @@ {:else} { console.log('on:change', detail); diff --git a/src/components/NumberInput/NumberInput.stories.js b/src/components/NumberInput/NumberInput.stories.js index 0780a9fa..6e7893c7 100644 --- a/src/components/NumberInput/NumberInput.stories.js +++ b/src/components/NumberInput/NumberInput.stories.js @@ -6,7 +6,8 @@ export default { title: 'NumberInput', decorators: [withKnobs] }; export const Default = () => ({ Component, props: { - id: 'number-input', + id: text('NumberInput id', 'number-input-id'), + name: text('NumberInput name', 'number-input-name'), label: text('Label (label)', 'Number Input label'), hideLabel: boolean('Hide label (hideLabel)', false), min: number('Minimum value (min)', 0), diff --git a/src/components/NumberInput/NumberInput.svelte b/src/components/NumberInput/NumberInput.svelte index cbd4f8d0..5714c206 100644 --- a/src/components/NumberInput/NumberInput.svelte +++ b/src/components/NumberInput/NumberInput.svelte @@ -8,6 +8,7 @@ export let hideLabel = false; export let iconDescription = ''; export let id = Math.random(); + export let name = Math.random(); export let invalid = false; export let invalidText = 'Provide invalidText'; export let mobile = false; @@ -96,6 +97,7 @@ }} {disabled} {id} + {name} {max} {min} {step} diff --git a/src/components/Select/Select.Story.svelte b/src/components/Select/Select.Story.svelte index a911509b..ceaa58fc 100644 --- a/src/components/Select/Select.Story.svelte +++ b/src/components/Select/Select.Story.svelte @@ -16,7 +16,7 @@ {#if story === 'skeleton'} {:else} -