From 70c622f9eb60767d62c75ec85b2d35eb416d642b Mon Sep 17 00:00:00 2001 From: Eric Liu Date: Sat, 12 Mar 2022 19:05:39 -0800 Subject: [PATCH] refactor(data-table): reuse rowIds --- src/DataTable/DataTable.svelte | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/DataTable/DataTable.svelte b/src/DataTable/DataTable.svelte index 0c33d289..b8ffb16b 100644 --- a/src/DataTable/DataTable.svelte +++ b/src/DataTable/DataTable.svelte @@ -174,12 +174,13 @@ let refSelectAll = null; $: batchSelectedIds.set(selectedRowIds); - $: expandableRowIds = rows - .map((row) => row.id) - .filter((id) => !nonExpandableRowIds.includes(id)); - $: selectableRowIds = rows - .map((row) => row.id) - .filter((id) => !nonSelectableRowIds.includes(id)); + $: rowIds = rows.map((row) => row.id); + $: expandableRowIds = rowIds.filter( + (id) => !nonExpandableRowIds.includes(id) + ); + $: selectableRowIds = rowIds.filter( + (id) => !nonSelectableRowIds.includes(id) + ); $: indeterminate = selectedRowIds.length > 0 && selectedRowIds.length < rows.length; $: if (batchExpansion) {