From 73385bf598740f616946e974b94c970d8b8e3825 Mon Sep 17 00:00:00 2001
From: metonym <ericyl.us@gmail.com>
Date: Mon, 5 Sep 2022 08:22:58 -0700
Subject: [PATCH] fix(a11y): resolve accessibility warnings in Svelte 3.50.0
 (#1480)

Fixes #1479

* chore(deps-dev): upgrade svelte 3.47.0 -> 3.50.0

* fix(toggle): ignore `a11y-role-has-required-aria-props` warning

* fix(header-search): resolve a11y warnings
---
 package.json                    | 2 +-
 src/Toggle/Toggle.svelte        | 1 +
 src/UIShell/HeaderSearch.svelte | 7 +++++--
 yarn.lock                       | 7 ++++++-
 4 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/package.json b/package.json
index f1f2e76d..df55707e 100644
--- a/package.json
+++ b/package.json
@@ -39,7 +39,7 @@
     "rollup-plugin-terser": "^7.0.2",
     "sass": "^1.49.11",
     "sveld": "^0.17.2",
-    "svelte": "^3.46.6",
+    "svelte": "^3.50.0",
     "svelte-check": "^2.8.1",
     "typescript": "^4.7.4"
   },
diff --git a/src/Toggle/Toggle.svelte b/src/Toggle/Toggle.svelte
index b71732d2..01f69af9 100644
--- a/src/Toggle/Toggle.svelte
+++ b/src/Toggle/Toggle.svelte
@@ -53,6 +53,7 @@
   on:mouseenter
   on:mouseleave
 >
+  <!-- svelte-ignore a11y-role-has-required-aria-props -->
   <input
     role="switch"
     type="checkbox"
diff --git a/src/UIShell/HeaderSearch.svelte b/src/UIShell/HeaderSearch.svelte
index 7d101f99..85e565e2 100644
--- a/src/UIShell/HeaderSearch.svelte
+++ b/src/UIShell/HeaderSearch.svelte
@@ -61,10 +61,11 @@
 
 <div bind:this="{refSearch}" role="search" class:active>
   <label for="search-input" id="search-label">Search</label>
-  <div role="combobox" aria-expanded="{active}">
+  <div aria-owns="search-menu" aria-haspopup="menu">
     <button
       type="button"
       aria-label="Search"
+      aria-expanded="{active}"
       tabindex="{active ? '-1' : '0'}"
       class:bx--header__action="{true}"
       class:disabled="{active}"
@@ -83,6 +84,8 @@
       class:active
       {...$$restProps}
       id="search-input"
+      aria-autocomplete="list"
+      aria-controls="search-menu"
       aria-activedescendant="{selectedId}"
       bind:value
       on:change
@@ -133,7 +136,7 @@
   {#if active && results.length > 0}
     <ul aria-labelledby="search-label" role="menu" id="search-menu">
       {#each results as result, i}
-        <li>
+        <li role="none">
           <a
             tabindex="-1"
             id="search-menuitem-{i}"
diff --git a/yarn.lock b/yarn.lock
index c335ae94..d8d01908 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -1414,11 +1414,16 @@ svelte-preprocess@^4.10.6:
     sorcery "^0.10.0"
     strip-indent "^3.0.0"
 
-svelte@^3.46.6, svelte@^3.47.0:
+svelte@^3.47.0:
   version "3.49.0"
   resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.49.0.tgz#5baee3c672306de1070c3b7888fc2204e36a4029"
   integrity sha512-+lmjic1pApJWDfPCpUUTc1m8azDqYCG1JN9YEngrx/hUyIcFJo6VZhj0A1Ai0wqoHcEIuQy+e9tk+4uDgdtsFA==
 
+svelte@^3.50.0:
+  version "3.50.0"
+  resolved "https://registry.yarnpkg.com/svelte/-/svelte-3.50.0.tgz#d11a7a6bd1e084ec051d55104a9af8bccf54461f"
+  integrity sha512-zXeOUDS7+85i+RxLN+0iB6PMbGH7OhEgjETcD1fD8ZrhuhNFxYxYEHU41xuhkHIulJavcu3PKbPyuCrBxdxskQ==
+
 terser@^5.0.0:
   version "5.14.2"
   resolved "https://registry.yarnpkg.com/terser/-/terser-5.14.2.tgz#9ac9f22b06994d736174f4091aa368db896f1c10"