mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-15 10:21:05 +00:00
Code Issues Projects Releases Packages Wiki Activity

Overflow menu first time open behavior is not correct (#477)

Browse source 
* Close overflow menu on focusout

* fix styling and behavior of overflow menu,
 when it is opened for the first time

* remove previous commit

* Fix keyboard navigation of overflow menu items
This commit is contained in:
Erik-Jan 2021-01-08 23:59:33 +01:00 • committed by GitHub
commit 775ceb47c1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/OverflowMenu/OverflowMenu.svelte
View file

@ -66,7 +66,7 @@
const currentIndex = writable(-1); const currentIndex = writable(-1);
let buttonWidth = undefined; let buttonWidth = undefined;
let didOpen = false; let onMountAfterUpdate = true;
setContext("OverflowMenu", { setContext("OverflowMenu", {
focusedId, focusedId,
@ -108,7 +108,7 @@
buttonWidth = width; buttonWidth = width;
if ($currentIndex < 0) { if (!onMountAfterUpdate && $currentIndex < 0) {
menuRef.focus(); menuRef.focus();
} }
@ -125,15 +125,13 @@
} }
} }
if (didOpen && !open) { if (!open) {
items.set([]); items.set([]);
currentId.set(undefined); currentId.set(undefined);
currentIndex.set(0); currentIndex.set(0);
} }
if (!didOpen && open) { onMountAfterUpdate = false;
didOpen = true;
}
}); });
$: ariaLabel = $$props["aria-label"] || "menu"; $: ariaLabel = $$props["aria-label"] || "menu";