From 7a21a3150e38e8d61e1e855898921eced04ec0a5 Mon Sep 17 00:00:00 2001 From: Eric Liu Date: Wed, 18 Dec 2019 09:26:31 -0800 Subject: [PATCH] refactor(inline-loading): remove exported props Supports #7 --- .../InlineLoading/InlineLoading.Story.svelte | 6 +----- src/components/InlineLoading/InlineLoading.svelte | 15 +++++++++++---- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/src/components/InlineLoading/InlineLoading.Story.svelte b/src/components/InlineLoading/InlineLoading.Story.svelte index 70196dc6..ffef6daf 100644 --- a/src/components/InlineLoading/InlineLoading.Story.svelte +++ b/src/components/InlineLoading/InlineLoading.Story.svelte @@ -41,10 +41,6 @@ display: flex; width: 300px; } - - :global(.loader) { - margin-left: 1rem; - } @@ -53,7 +49,7 @@ {#if disabled} diff --git a/src/components/InlineLoading/InlineLoading.svelte b/src/components/InlineLoading/InlineLoading.svelte index f848dfde..1f5c1e8f 100644 --- a/src/components/InlineLoading/InlineLoading.svelte +++ b/src/components/InlineLoading/InlineLoading.svelte @@ -6,7 +6,7 @@ export let description = undefined; export let iconDescription = undefined; export let successDelay = 1500; - export let props = {}; + export let style = undefined; import { createEventDispatcher, onDestroy } from 'svelte'; import CheckmarkFilled16 from 'carbon-icons-svelte/lib/CheckmarkFilled16'; @@ -20,19 +20,26 @@ onDestroy(() => { if (timeoutId !== undefined) { - clearTimeout(timeoutId); + window.clearTimeout(timeoutId); timeoutId = undefined; } }); $: if (status === 'finished') { - timeoutId = setTimeout(() => { + timeoutId = window.setTimeout(() => { dispatch('success'); }, successDelay); } -
+
{#if status === 'error'}