mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-15 18:31:06 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #329 from IBM/combobox-disabled

Browse source 
fix(combo-box): disabled combobox should not open
This commit is contained in:
Eric Liu 2020-10-14 16:06:43 -07:00 • committed by GitHub
commit 87908ffbd5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
docs/src/pages/components/ComboBox.svx
View file

@ -57,8 +57,7 @@ items={[
### Disabled ### Disabled
<ComboBox titleText="Contact" placeholder="Select contact method" <ComboBox disabled titleText="Contact" placeholder="Select contact method"
disabled
items={[ items={[
{id: "0", text: "Slack"}, {id: "0", text: "Slack"},
{id: "1", text: "Email"}, {id: "1", text: "Email"},

1
src/ComboBox/ComboBox.svelte
View file

@ -203,6 +203,7 @@
role="button" role="button"
aria-expanded="{open}" aria-expanded="{open}"
on:click="{() => { on:click="{() => {
if (disabled) return;
open = true; open = true;
}}" }}"
id="{id}" id="{id}"