From 89513fb4cb0296dd83f92e683e9a37afaf964332 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nguy=E1=BB=85n=20Tr=C6=B0=E1=BB=9Dng=20Minh?= <3071451+truongminh@users.noreply.github.com> Date: Thu, 15 Jul 2021 06:37:42 -0700 Subject: [PATCH] fix(DataTable): undefined cell value fallback (#745) * fix(DataTable): undefined cell value fallback * Update DataTable.svelte * fix(data-table): remove "" as the default value for table cells Co-authored-by: Eric Y Liu --- src/DataTable/DataTable.svelte | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/DataTable/DataTable.svelte b/src/DataTable/DataTable.svelte index cd35c63d..5eb140d3 100644 --- a/src/DataTable/DataTable.svelte +++ b/src/DataTable/DataTable.svelte @@ -127,14 +127,11 @@ .map(({ key }, i) => ({ key, id: $headerItems[i] })) .reduce((a, c) => ({ ...a, [c.key]: c.id }), {}) ); - const resolvePath = (object, path, defaultValue) => + const resolvePath = (object, path) => path .split(/[\.\[\]\'\"]/) .filter((p) => p) - .reduce( - (o, p) => (o && typeof o === "object" && o[p] ? o[p] : defaultValue), - object - ); + .reduce((o, p) => (o && typeof o === "object" ? o[p] : o), object); setContext("DataTable", { sortHeader, @@ -172,7 +169,7 @@ ...row, cells: headerKeys.map((key, index) => ({ key, - value: resolvePath(row, key, ""), + value: resolvePath(row, key), display: headers[index].display, })), }));