From 8cb5d538f7ad10d7c93e10c04f01d2c77b4eba44 Mon Sep 17 00:00:00 2001
From: ptrxyz <ptrxyz@gmail.com>
Date: Wed, 25 Jan 2023 04:28:36 +0100
Subject: [PATCH] fix(dropdown): fix ssr issue (#1639)

The `onDestroy` hook is also run during SSR, so returning destruction function from `onMount` should do the trick. For #1638
---
 src/Dropdown/Dropdown.svelte | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/Dropdown/Dropdown.svelte b/src/Dropdown/Dropdown.svelte
index 98764b4c..aa30290f 100644
--- a/src/Dropdown/Dropdown.svelte
+++ b/src/Dropdown/Dropdown.svelte
@@ -98,7 +98,7 @@
   /** Obtain a reference to the button HTML element */
   export let ref = null;
 
-  import { createEventDispatcher, onDestroy, onMount } from "svelte";
+  import { createEventDispatcher, onMount } from "svelte";
   import WarningFilled from "../icons/WarningFilled.svelte";
   import WarningAltFilled from "../icons/WarningAltFilled.svelte";
   import {
@@ -159,11 +159,11 @@
     if (parent) {
       parent.addEventListener("click", pageClickHandler);
     }
-  });
 
-  onDestroy(() => {
-    if (parent) {
-      parent.removeEventListener("click", pageClickHandler);
+    return () => {
+      if (parent) {
+        parent.removeEventListener("click", pageClickHandler);
+      }
     }
   });
 </script>