mirror of
https://github.com/carbon-design-system/carbon-components-svelte.git
synced 2025-09-15 02:11:05 +00:00
fix: use native binding for value
prop in ComboBox
, MultiSelect
(#1343)
* fix(combo-box): use native binding for value prop (fixes #1262) * fix(multi-select): use native binding for value prop
This commit is contained in:
parent
2c05f35c48
commit
8e52e13ee9
2 changed files with 17 additions and 25 deletions
|
@ -121,7 +121,6 @@
|
|||
const dispatch = createEventDispatcher();
|
||||
|
||||
let selectedItem = undefined;
|
||||
let inputValue = value;
|
||||
let prevSelectedId = null;
|
||||
let highlightedIndex = -1;
|
||||
|
||||
|
@ -161,7 +160,7 @@
|
|||
selectedId = undefined;
|
||||
selectedItem = undefined;
|
||||
open = false;
|
||||
inputValue = "";
|
||||
value = "";
|
||||
if (options?.focus !== false) ref?.focus();
|
||||
}
|
||||
|
||||
|
@ -174,12 +173,12 @@
|
|||
filteredItems = [];
|
||||
if (!selectedItem) {
|
||||
selectedId = undefined;
|
||||
inputValue = "";
|
||||
value = "";
|
||||
highlightedIndex = -1;
|
||||
highlightedId = undefined;
|
||||
} else {
|
||||
// programmatically set inputValue
|
||||
inputValue = selectedItem.text;
|
||||
// programmatically set value
|
||||
value = selectedItem.text;
|
||||
}
|
||||
}
|
||||
});
|
||||
|
@ -207,7 +206,6 @@
|
|||
$: comboId = `combo-${id}`;
|
||||
$: highlightedId = items[highlightedIndex] ? items[highlightedIndex].id : 0;
|
||||
$: filteredItems = items.filter((item) => shouldFilterItem(item, value));
|
||||
$: value = inputValue;
|
||||
</script>
|
||||
|
||||
<svelte:window
|
||||
|
@ -257,6 +255,7 @@
|
|||
>
|
||||
<input
|
||||
bind:this="{ref}"
|
||||
bind:value
|
||||
tabindex="0"
|
||||
autocomplete="off"
|
||||
aria-autocomplete="list"
|
||||
|
@ -269,19 +268,17 @@
|
|||
disabled="{disabled}"
|
||||
placeholder="{placeholder}"
|
||||
id="{id}"
|
||||
value="{inputValue}"
|
||||
name="{name}"
|
||||
{...$$restProps}
|
||||
class:bx--text-input="{true}"
|
||||
class:bx--text-input--light="{light}"
|
||||
class:bx--text-input--empty="{inputValue === ''}"
|
||||
on:input="{async ({ target }) => {
|
||||
class:bx--text-input--empty="{value === ''}"
|
||||
on:input="{({ target }) => {
|
||||
if (!open && target.value.length > 0) {
|
||||
open = true;
|
||||
}
|
||||
|
||||
inputValue = target.value;
|
||||
if (!inputValue.length) {
|
||||
if (!value.length) {
|
||||
clear();
|
||||
open = true;
|
||||
}
|
||||
|
@ -297,14 +294,14 @@
|
|||
) {
|
||||
open = false;
|
||||
if (filteredItems[highlightedIndex]) {
|
||||
inputValue = filteredItems[highlightedIndex].text;
|
||||
value = filteredItems[highlightedIndex].text;
|
||||
selectedItem = filteredItems[highlightedIndex];
|
||||
selectedId = filteredItems[highlightedIndex].id;
|
||||
}
|
||||
} else {
|
||||
open = false;
|
||||
if (filteredItems[0]) {
|
||||
inputValue = filteredItems[0].text;
|
||||
value = filteredItems[0].text;
|
||||
selectedItem = filteredItems[0];
|
||||
selectedId = filteredItems[0].id;
|
||||
}
|
||||
|
@ -344,7 +341,7 @@
|
|||
class="bx--list-box__invalid-icon bx--list-box__invalid-icon--warning"
|
||||
/>
|
||||
{/if}
|
||||
{#if inputValue}
|
||||
{#if value}
|
||||
<ListBoxSelection
|
||||
on:clear
|
||||
on:clear="{clear}"
|
||||
|
@ -385,7 +382,7 @@
|
|||
open = false;
|
||||
|
||||
if (filteredItems[i]) {
|
||||
inputValue = filteredItems[i].text;
|
||||
value = filteredItems[i].text;
|
||||
}
|
||||
}}"
|
||||
on:mouseenter="{() => {
|
||||
|
|
|
@ -183,7 +183,6 @@
|
|||
|
||||
const dispatch = createEventDispatcher();
|
||||
|
||||
let inputValue = "";
|
||||
let initialSorted = false;
|
||||
let highlightedIndex = -1;
|
||||
let prevChecked = [];
|
||||
|
@ -255,7 +254,7 @@
|
|||
}
|
||||
|
||||
highlightedIndex = -1;
|
||||
inputValue = "";
|
||||
value = "";
|
||||
}
|
||||
|
||||
items = sortedItems;
|
||||
|
@ -275,7 +274,6 @@
|
|||
highlightedIndex > -1
|
||||
? (filterable ? filteredItems : sortedItems)[highlightedIndex]?.id ?? null
|
||||
: null;
|
||||
$: value = inputValue;
|
||||
</script>
|
||||
|
||||
<svelte:window
|
||||
|
@ -403,6 +401,7 @@
|
|||
{#if filterable}
|
||||
<input
|
||||
bind:this="{inputRef}"
|
||||
bind:value
|
||||
{...$$restProps}
|
||||
role="combobox"
|
||||
tabindex="0"
|
||||
|
@ -413,11 +412,8 @@
|
|||
aria-disabled="{disabled}"
|
||||
aria-controls="{menuId}"
|
||||
class:bx--text-input="{true}"
|
||||
class:bx--text-input--empty="{inputValue === ''}"
|
||||
class:bx--text-input--empty="{value === ''}"
|
||||
class:bx--text-input--light="{light}"
|
||||
on:input="{({ target }) => {
|
||||
inputValue = target.value;
|
||||
}}"
|
||||
on:keydown
|
||||
on:keydown|stopPropagation="{({ key }) => {
|
||||
if (key === 'Enter') {
|
||||
|
@ -451,15 +447,14 @@
|
|||
placeholder="{placeholder}"
|
||||
id="{id}"
|
||||
name="{name}"
|
||||
value="{inputValue}"
|
||||
/>
|
||||
{#if invalid}
|
||||
<WarningFilled class="bx--list-box__invalid-icon" />
|
||||
{/if}
|
||||
{#if inputValue}
|
||||
{#if value}
|
||||
<ListBoxSelection
|
||||
on:clear="{() => {
|
||||
inputValue = '';
|
||||
value = '';
|
||||
open = false;
|
||||
}}"
|
||||
translateWithId="{translateWithIdSelection}"
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue