mirror of
https://github.com/carbon-design-system/carbon-components-svelte.git
synced 2025-09-14 18:01:06 +00:00
fix(slider): dispatch on:input
event (#1906)
Fixes #1643 The dispatched `on:change` event in `Slider` only fires when the slider thumb is released. `on:input` fires when actively dragging the thumb, and should fire on every increment (e.g., 1, 2, 3).
This commit is contained in:
parent
5c95891079
commit
90dbd1562b
5 changed files with 8 additions and 0 deletions
|
@ -3533,6 +3533,7 @@ None.
|
|||
| Event name | Type | Detail |
|
||||
| :--------- | :--------- | :------------------ |
|
||||
| change | dispatched | <code>number</code> |
|
||||
| input | dispatched | <code>number</code> |
|
||||
| click | forwarded | -- |
|
||||
| mouseover | forwarded | -- |
|
||||
| mouseenter | forwarded | -- |
|
||||
|
|
|
@ -11361,6 +11361,7 @@
|
|||
],
|
||||
"events": [
|
||||
{ "type": "dispatched", "name": "change", "detail": "number" },
|
||||
{ "type": "dispatched", "name": "input", "detail": "number" },
|
||||
{ "type": "forwarded", "name": "click", "element": "div" },
|
||||
{ "type": "forwarded", "name": "mouseover", "element": "div" },
|
||||
{ "type": "forwarded", "name": "mouseenter", "element": "div" },
|
||||
|
|
|
@ -1,6 +1,7 @@
|
|||
<script>
|
||||
/**
|
||||
* @event {number} change
|
||||
* @event {number} input
|
||||
*/
|
||||
|
||||
/** Specify the value of the slider */
|
||||
|
@ -109,6 +110,7 @@
|
|||
}
|
||||
|
||||
value = nextValue;
|
||||
dispatch("input", value);
|
||||
}
|
||||
|
||||
$: labelId = `label-${id}`;
|
||||
|
|
|
@ -14,6 +14,9 @@
|
|||
on:change="{(e) => {
|
||||
console.log(e.detail); // number
|
||||
}}"
|
||||
on:input="{(e) => {
|
||||
console.log(e.detail); // number
|
||||
}}"
|
||||
/>
|
||||
|
||||
<Slider
|
||||
|
|
1
types/Slider/Slider.svelte.d.ts
vendored
1
types/Slider/Slider.svelte.d.ts
vendored
|
@ -127,6 +127,7 @@ export default class Slider extends SvelteComponentTyped<
|
|||
SliderProps,
|
||||
{
|
||||
change: CustomEvent<number>;
|
||||
input: CustomEvent<number>;
|
||||
click: WindowEventMap["click"];
|
||||
mouseover: WindowEventMap["mouseover"];
|
||||
mouseenter: WindowEventMap["mouseenter"];
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue