From 95b32937d6b8827e4b26554f541db86ca828b1c8 Mon Sep 17 00:00:00 2001 From: metonym Date: Sun, 5 Jun 2022 14:24:37 -0700 Subject: [PATCH] perf(data-table): save rows reference when reducing (#1338) https://github.com/carbon-design-system/carbon-components-svelte/commit/d2cdb8eb0f5a1bdf3e7e8d01ae859542d470c9d4#r75383503 --- src/DataTable/DataTable.svelte | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/src/DataTable/DataTable.svelte b/src/DataTable/DataTable.svelte index f1472a06..7d1954ae 100644 --- a/src/DataTable/DataTable.svelte +++ b/src/DataTable/DataTable.svelte @@ -199,17 +199,14 @@ } $: if (radio || batchSelection) selectable = true; $: headerKeys = headers.map(({ key }) => key); - $: tableCellsByRowId = rows.reduce( - (rows, row) => ({ - ...rows, - [row.id]: headerKeys.map((key, index) => ({ - key, - value: resolvePath(row, key), - display: headers[index].display, - })), - }), - {} - ); + $: tableCellsByRowId = rows.reduce((rows, row) => { + rows[row.id] = headerKeys.map((key, index) => ({ + key, + value: resolvePath(row, key), + display: headers[index].display, + })); + return rows; + }, {}); $: $tableRows = rows; $: sortedRows = [...$tableRows]; $: ascending = sortDirection === "ascending";