From 98327385fda9f27e9c75d8155f1e6d9c14f98c1c Mon Sep 17 00:00:00 2001 From: jqlio18 Date: Thu, 22 Dec 2022 11:58:42 -0500 Subject: [PATCH] `onDestroy` we want to remove the event listener to prevent listeners hanging --- src/Dropdown/Dropdown.svelte | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/Dropdown/Dropdown.svelte b/src/Dropdown/Dropdown.svelte index 537fe419..98764b4c 100644 --- a/src/Dropdown/Dropdown.svelte +++ b/src/Dropdown/Dropdown.svelte @@ -98,7 +98,7 @@ /** Obtain a reference to the button HTML element */ export let ref = null; - import { createEventDispatcher, onMount } from "svelte"; + import { createEventDispatcher, onDestroy, onMount } from "svelte"; import WarningFilled from "../icons/WarningFilled.svelte"; import WarningAltFilled from "../icons/WarningAltFilled.svelte"; import { @@ -160,6 +160,12 @@ parent.addEventListener("click", pageClickHandler); } }); + + onDestroy(() => { + if (parent) { + parent.removeEventListener("click", pageClickHandler); + } + });