mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-15 10:21:05 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix(tabs): dispatch "change" event only if index has changed (#1279)

Browse source 
Fixes #1278
This commit is contained in:
metonym 2022-05-02 20:48:59 -07:00 • committed by GitHub
commit 9911764df1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/Tabs/Tabs.svelte
View file

@ -52,7 +52,6 @@
}, },
update: (id) => { update: (id) => {
currentIndex = $tabsById[id].index; currentIndex = $tabsById[id].index;
dispatch("change", currentIndex);
}, },
change: (direction) => { change: (direction) => {
let index = currentIndex + direction; let index = currentIndex + direction;
@ -78,16 +77,22 @@
} }
currentIndex = index; currentIndex = index;
dispatch("change", currentIndex);
}, },
}); });
afterUpdate(() => { afterUpdate(() => {
selected = currentIndex; selected = currentIndex;
if (prevIndex > -1 && prevIndex !== currentIndex) {
dispatch("change", currentIndex);
}
prevIndex = currentIndex;
}); });
let dropdownHidden = true; let dropdownHidden = true;
let currentIndex = selected; let currentIndex = selected;
let prevIndex = -1;
$: currentIndex = selected; $: currentIndex = selected;
$: currentTab = $tabs[currentIndex] || undefined; $: currentTab = $tabs[currentIndex] || undefined;