mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-14 18:01:06 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix(list-box): set aria-disabled if disabled (#2125) (#2138)

Browse source 
Re-apply #2125 (reverted in #2130) to preserve `disabled` attribute.

Carbon styles depend on the `[disabled]` attribute. However, the `disabled`
attribute is not valid markup when applied to `div role="option"`. This PR
preserves the existing `disabled` attribute while also setting `aria-disabled`
to maintain accessibility.
This commit is contained in:
Eric Liu 2025-03-23 10:46:25 -07:00 • committed by GitHub
commit 9b61af0306
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/ListBox/ListBoxMenuItem.svelte
View file

@ -25,6 +25,7 @@
class:bx--list-box__menu-item--active={active} class:bx--list-box__menu-item--active={active}
class:bx--list-box__menu-item--highlighted={highlighted || active} class:bx--list-box__menu-item--highlighted={highlighted || active}
aria-selected={active} aria-selected={active}
aria-disabled={disabled ? true : undefined}
disabled={disabled ? true : undefined} disabled={disabled ? true : undefined}
{...$$restProps} {...$$restProps}
on:click on:click

1
tests/ComboBox/ComboBox.test.ts
View file

@ -166,6 +166,7 @@ describe("ComboBox", () => {
const disabledOption = screen.getByText(/Fax/).closest('[role="option"]'); const disabledOption = screen.getByText(/Fax/).closest('[role="option"]');
assert(disabledOption); assert(disabledOption);
expect(disabledOption).toHaveAttribute("disabled", "true"); expect(disabledOption).toHaveAttribute("disabled", "true");
expect(disabledOption).toHaveAttribute("aria-disabled", "true");
await user.click(disabledOption); await user.click(disabledOption);
expect(screen.getByRole("textbox")).toHaveValue(""); expect(screen.getByRole("textbox")).toHaveValue("");