From 9e5adfa9862fe380eb87be5f49545825588b3ae1 Mon Sep 17 00:00:00 2001 From: Eric Y Liu Date: Wed, 14 Jul 2021 09:37:16 -0700 Subject: [PATCH] fix(number-input): do not dispatch change event on initialization #561 Fixes #561 --- src/NumberInput/NumberInput.svelte | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/NumberInput/NumberInput.svelte b/src/NumberInput/NumberInput.svelte index ea93b23e..e74c1b36 100644 --- a/src/NumberInput/NumberInput.svelte +++ b/src/NumberInput/NumberInput.svelte @@ -103,7 +103,7 @@ /** Obtain a reference to the input HTML element */ export let ref = null; - import { createEventDispatcher, afterUpdate } from "svelte"; + import { createEventDispatcher } from "svelte"; import Add16 from "carbon-icons-svelte/lib/Add16/Add16.svelte"; import Subtract16 from "carbon-icons-svelte/lib/Subtract16/Subtract16.svelte"; import WarningFilled16 from "carbon-icons-svelte/lib/WarningFilled16/WarningFilled16.svelte"; @@ -129,12 +129,9 @@ } } - afterUpdate(() => { - dispatch("change", value); - }); - let inputValue = value; + $: dispatch("change", value); $: incrementLabel = translateWithId("increment"); $: decrementLabel = translateWithId("decrement"); $: value = Number(inputValue);