From a4d68e7e00dcd92dec9486a3030f7239d8ad4286 Mon Sep 17 00:00:00 2001
From: Eric Liu <ericyl.us@gmail.com>
Date: Mon, 14 Sep 2020 06:49:42 -0700
Subject: [PATCH] fix(side-nav-menu): fix a11y warnings

- remove role attributes from SideNavMenuItem
- remove "aria-haspopup" from SideNavMenu
---
 src/UIShell/SideNav/SideNavMenu.svelte     | 1 -
 src/UIShell/SideNav/SideNavMenuItem.svelte | 3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/UIShell/SideNav/SideNavMenu.svelte b/src/UIShell/SideNav/SideNavMenu.svelte
index de3cbe23..dc239ca6 100644
--- a/src/UIShell/SideNav/SideNavMenu.svelte
+++ b/src/UIShell/SideNav/SideNavMenu.svelte
@@ -24,7 +24,6 @@
 <li class:bx--side-nav__item="{true}" class:bx--side-nav__item--icon="{icon}">
   <button
     type="button"
-    aria-haspopup="true"
     aria-expanded="{expanded}"
     class:bx--side-nav__submenu="{true}"
     {...$$restProps}
diff --git a/src/UIShell/SideNav/SideNavMenuItem.svelte b/src/UIShell/SideNav/SideNavMenuItem.svelte
index 9c38fbfc..8f6ebcfa 100644
--- a/src/UIShell/SideNav/SideNavMenuItem.svelte
+++ b/src/UIShell/SideNav/SideNavMenuItem.svelte
@@ -18,9 +18,8 @@
   export let text = undefined;
 </script>
 
-<li role="none" class:bx--side-nav__menu-item="{true}">
+<li class:bx--side-nav__menu-item="{true}">
   <a
-    role="menuitem"
     aria-current="{isSelected ? 'page' : undefined}"
     href="{href}"
     class:bx--side-nav__link="{true}"