Merge pull request #363 from IBM/fixes

Fixes
This commit is contained in:
Eric Liu 2020-10-24 15:22:09 -07:00 committed by GitHub
commit a58be75648
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
10 changed files with 49 additions and 82 deletions

View file

@ -1737,7 +1737,7 @@ import { Header } from "carbon-components-svelte";
| uiShellAriaLabel | <code>string</code> | -- | Specify the ARIA label for the header. |
| href | <code>string</code> | -- | Specify the `href` attribute. |
| company | <code>string</code> | -- | Specify the company name. |
| platformName | <code>string</code> | -- | Specify the platform name. Alternatively, use the named slot "platform" (e.g. &lt;span slot="platform"&gt;...&lt;/span&gt;). |
| platformName | <code>string</code> | `""` | Specify the platform name. Alternatively, use the named slot "platform" (e.g. &lt;span slot="platform"&gt;...&lt;/span&gt;). |
| ref | <code>null &#124; HTMLAnchorElement</code> | `null` | Obtain a reference to the HTML anchor element. |
### Slots

View file

@ -5361,6 +5361,7 @@
"platformName",
{
"kind": "let",
"value": "\"\"",
"type": "string",
"description": "Specify the platform name\nAlternatively, use the named slot \"platform\" (e.g. <span slot=\"platform\">...</span>)"
}
@ -5381,14 +5382,14 @@
{
"attributes": [
{
"start": 1398,
"end": 1420,
"start": 1394,
"end": 1416,
"type": "Attribute",
"name": "name",
"value": [
{
"start": 1404,
"end": 1419,
"start": 1400,
"end": 1415,
"type": "Text",
"raw": "skip-to-content",
"data": "skip-to-content"
@ -5406,14 +5407,14 @@
{
"attributes": [
{
"start": 1740,
"end": 1755,
"start": 1736,
"end": 1751,
"type": "Attribute",
"name": "name",
"value": [
{
"start": 1746,
"end": 1754,
"start": 1742,
"end": 1750,
"type": "Text",
"raw": "platform",
"data": "platform"
@ -5423,13 +5424,13 @@
],
"children": [
{
"start": 1756,
"end": 1770,
"start": 1752,
"end": 1766,
"type": "MustacheTag",
"expression": {
"type": "Identifier",
"start": 1757,
"end": 1769,
"start": 1753,
"end": 1765,
"loc": {
"start": {
"line": 72,
@ -5462,8 +5463,8 @@
[
"click",
{
"start": 1614,
"end": 1622,
"start": 1610,
"end": 1618,
"type": "EventHandler",
"name": "click",
"modifiers": [],
@ -5743,61 +5744,38 @@
},
{
"start": 608,
"end": 669,
"type": "IfBlock",
"end": 642,
"type": "InlineComponent",
"name": "svelte:component",
"attributes": [],
"children": [],
"expression": {
"type": "Identifier",
"start": 613,
"end": 617,
"start": 633,
"end": 637,
"loc": {
"start": {
"line": 30,
"column": 9
"column": 29
},
"end": {
"line": 30,
"column": 13
"column": 33
}
},
"name": "icon"
},
"children": [
{
"start": 625,
"end": 659,
"type": "InlineComponent",
"name": "svelte:component",
"attributes": [],
"children": [],
"expression": {
"type": "Identifier",
"start": 650,
"end": 654,
"loc": {
"start": {
"line": 31,
"column": 31
},
"end": {
"line": 31,
"column": 35
}
},
"name": "icon"
}
}
]
}
},
{
"start": 669,
"end": 672,
"start": 642,
"end": 645,
"type": "Text",
"raw": "\n ",
"data": "\n "
}
],
"default": true,
"default_value": "\n \n{#if icon}\n <svelte:component this=\"{icon}\" />\n {/if}\n\n \n"
"default_value": "\n \n<svelte:component this=\"{icon}\" />\n\n \n"
}
]
],

View file

@ -4,18 +4,11 @@
export let src = "";
export let framed = false;
import { CodeSnippet, Button, InlineLoading } from "carbon-components-svelte";
import { CodeSnippet, Button } from "carbon-components-svelte";
import Launch16 from "carbon-icons-svelte/lib/Launch16";
import copy from "clipboard-copy";
import { url, beforeUrlChange } from "@sveltech/routify";
import { theme } from "../store";
let success = false;
$beforeUrlChange(() => {
if (success) success = false;
return true;
});
</script>
<style global>
@ -135,10 +128,10 @@
<div class="preview">
{#if framed}
<div class="framed-header">
<div style="margin-left: var(--cds-spacing-03)">
{#if framed && !success}
<InlineLoading description="Loading..." />
{/if}
<div
style="margin-left: var(--cds-spacing-05); color: var(--cds-text-02)"
>
Content loaded in an iframe
</div>
<Button
style="margin-left: auto;"
@ -155,9 +148,6 @@
<div class="preview-viewer" class:framed>
{#if framed}
<iframe
on:load="{() => {
success = true;
}}"
title="{src.split('/').pop()}"
src="{$url(`${src}?theme=${$theme}`)}"
></iframe>

View file

@ -18,7 +18,7 @@ components: ["Accordion", "AccordionItem", "AccordionSkeleton"]
</p>
</AccordionItem>
<AccordionItem title="Natural Language Understanding">
Analyze text to extract meta-data from content such as concepts, entities, emotion, relations, sentiment and more.
<p>Analyze text to extract meta-data from content such as concepts, entities, emotion, relations, sentiment and more.</p>
</AccordionItem>
<AccordionItem title="Language Translator">
<p>Translate text, documents, and websites from one language to another. Create industry or region-specific translations via the service's customization capability.</p>
@ -33,7 +33,7 @@ components: ["Accordion", "AccordionItem", "AccordionSkeleton"]
</p>
</AccordionItem>
<AccordionItem title="Natural Language Understanding">
Analyze text to extract meta-data from content such as concepts, entities, emotion, relations, sentiment and more.
<p>Analyze text to extract meta-data from content such as concepts, entities, emotion, relations, sentiment and more.</p>
</AccordionItem>
<AccordionItem title="Language Translator">
<p>Translate text, documents, and websites from one language to another. Create industry or region-specific translations via the service's customization capability.</p>
@ -56,7 +56,7 @@ components: ["Accordion", "AccordionItem", "AccordionSkeleton"]
<h5>Natural Language Understanding</h5>
<div>AI / Machine Learning</div>
</div>
Analyze text to extract meta-data from content such as concepts, entities, emotion, relations, sentiment and more.
<p>Analyze text to extract meta-data from content such as concepts, entities, emotion, relations, sentiment and more.</p>
</AccordionItem>
<AccordionItem>
<div slot="title">
@ -75,7 +75,7 @@ components: ["Accordion", "AccordionItem", "AccordionSkeleton"]
</p>
</AccordionItem>
<AccordionItem title="Natural Language Understanding">
Analyze text to extract meta-data from content such as concepts, entities, emotion, relations, sentiment and more.
<p>Analyze text to extract meta-data from content such as concepts, entities, emotion, relations, sentiment and more.</p>
</AccordionItem>
<AccordionItem title="Language Translator">
<p>Translate text, documents, and websites from one language to another. Create industry or region-specific translations via the service's customization capability.</p>
@ -90,7 +90,7 @@ components: ["Accordion", "AccordionItem", "AccordionSkeleton"]
</p>
</AccordionItem>
<AccordionItem title="Natural Language Understanding">
Analyze text to extract meta-data from content such as concepts, entities, emotion, relations, sentiment and more.
<p>Analyze text to extract meta-data from content such as concepts, entities, emotion, relations, sentiment and more.</p>
</AccordionItem>
<AccordionItem title="Language Translator">
<p>Translate text, documents, and websites from one language to another. Create industry or region-specific translations via the service's customization capability.</p>
@ -105,7 +105,7 @@ components: ["Accordion", "AccordionItem", "AccordionSkeleton"]
</p>
</AccordionItem>
<AccordionItem title="Natural Language Understanding">
Analyze text to extract meta-data from content such as concepts, entities, emotion, relations, sentiment and more.
<p>Analyze text to extract meta-data from content such as concepts, entities, emotion, relations, sentiment and more.</p>
</AccordionItem>
<AccordionItem title="Language Translator">
<p>Translate text, documents, and websites from one language to another. Create industry or region-specific translations via the service's customization capability.</p>
@ -120,7 +120,7 @@ components: ["Accordion", "AccordionItem", "AccordionSkeleton"]
</p>
</AccordionItem>
<AccordionItem title="Natural Language Understanding">
Analyze text to extract meta-data from content such as concepts, entities, emotion, relations, sentiment and more.
<p>Analyze text to extract meta-data from content such as concepts, entities, emotion, relations, sentiment and more.</p>
</AccordionItem>
<AccordionItem title="Language Translator">
<p>Translate text, documents, and websites from one language to another. Create industry or region-specific translations via the service's customization capability.</p>
@ -135,7 +135,7 @@ components: ["Accordion", "AccordionItem", "AccordionSkeleton"]
</p>
</AccordionItem>
<AccordionItem title="Natural Language Understanding">
Analyze text to extract meta-data from content such as concepts, entities, emotion, relations, sentiment and more.
<p>Analyze text to extract meta-data from content such as concepts, entities, emotion, relations, sentiment and more.</p>
</AccordionItem>
<AccordionItem title="Language Translator">
<p>Translate text, documents, and websites from one language to another. Create industry or region-specific translations via the service's customization capability.</p>

View file

@ -285,7 +285,7 @@
</ListBoxField>
{#if open}
<ListBoxMenu aria-label="{ariaLabel}" id="{id}">
{#each filteredItems as item, i (item.id || i)}
{#each filteredItems as item, i (item.id)}
<ListBoxMenuItem
id="{item.id}"
active="{selectedIndex === i || selectedId === item.id}"

View file

@ -235,7 +235,7 @@
</button>
{#if open}
<ListBoxMenu aria-labelledby="{id}" id="{id}">
{#each items as item, i (item.id || i)}
{#each items as item, i (item.id)}
<ListBoxMenuItem
id="{item.id}"
active="{selectedIndex === i || selectedId === item.id}"

View file

@ -420,7 +420,7 @@
</ListBoxField>
{#if open}
<ListBoxMenu aria-label="{ariaLabel}" id="{id}">
{#each filterable ? filteredItems : sortedItems as item, i (item.id || i)}
{#each filterable ? filteredItems : sortedItems as item, i (item.id)}
<ListBoxMenuItem
id="{item.id}"
active="{item.checked}"

View file

@ -32,9 +32,9 @@
/**
* Specify the platform name
* Alternatively, use the named slot "platform" (e.g. <span slot="platform">...</span>)
* @type {string} [platformName]
* @type {string} [platformName=""]
*/
export let platformName = undefined;
export let platformName = "";
/**
* Obtain a reference to the HTML anchor element

View file

@ -27,8 +27,6 @@
on:click
>
<slot>
{#if icon}
<svelte:component this="{icon}" />
{/if}
<svelte:component this="{icon}" />
</slot>
</button>

1
types/index.d.ts vendored
View file

@ -1683,6 +1683,7 @@ export class Header extends CarbonSvelteComponent {
/**
* Specify the platform name
* Alternatively, use the named slot "platform" (e.g. <span slot="platform">...</span>)
* @default ""
*/
platformName?: string;