mcp/carbon-components-svelte
1
0
Fork 0
mirror of https://github.com/carbon-design-system/carbon-components-svelte.git synced 2025-09-17 11:11:25 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix(data-table): headers should be reactive (#1075)

Browse source 
If `headers` is dynamically updated, clicking a sortable table header will sort the incorrect column. Instead of randomly generating an id and keeping track of it through context, we can simply use the required key in `headers` as the id.
This commit is contained in:
metonym 2022-02-09 19:48:20 -08:00 • committed by GitHub
commit a5f5550aa0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/DataTable/TableHeader.svelte
View file

@ -18,9 +18,7 @@
import ArrowUp20 from "../icons/ArrowUp20.svelte";
import ArrowsVertical20 from "../icons/ArrowsVertical20.svelte";
const { sortHeader, tableSortable, add } = getContext("DataTable");
add(id);
const { sortHeader, tableSortable } = getContext("DataTable");
$: active = $sortHeader.id === id;
// TODO: translate with id