From af1caf97bf1f7dc8543e8d059f3914fc3f626974 Mon Sep 17 00:00:00 2001 From: Eric Y Liu Date: Wed, 14 Jul 2021 09:33:01 -0700 Subject: [PATCH] fix(overflow-menu): update semantic attributes in OverflowMenuItem --- src/OverflowMenu/OverflowMenuItem.svelte | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/OverflowMenu/OverflowMenuItem.svelte b/src/OverflowMenu/OverflowMenuItem.svelte index 4fb2718f..d12678e8 100644 --- a/src/OverflowMenu/OverflowMenuItem.svelte +++ b/src/OverflowMenu/OverflowMenuItem.svelte @@ -43,16 +43,17 @@ $: primaryFocus = $focusedId === id; $: buttonProps = { + role: "menuitem", tabindex: "-1", - title: requireTitle ? text : undefined, class: "bx--overflow-menu-options__btn", disabled: href ? undefined : disabled, href: href ? href : undefined, + title: requireTitle ? text : undefined, };