From ba7cb10aa302bebb930339d4321ef51b8b21ac9f Mon Sep 17 00:00:00 2001
From: Eric Liu <ericyl.us@gmail.com>
Date: Tue, 26 May 2020 19:14:03 -0700
Subject: [PATCH] fix(ui-shell): replace javascript:void(0) in HeaderNavMenu

Resolves an a11y "X is not a valid attribute" warning.

#184
---
 src/components/UIShell/GlobalHeader/HeaderNavMenu.svelte | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/components/UIShell/GlobalHeader/HeaderNavMenu.svelte b/src/components/UIShell/GlobalHeader/HeaderNavMenu.svelte
index b00da895..c60221b9 100644
--- a/src/components/UIShell/GlobalHeader/HeaderNavMenu.svelte
+++ b/src/components/UIShell/GlobalHeader/HeaderNavMenu.svelte
@@ -2,6 +2,8 @@
   export let text = undefined;
   export let iconDescription = 'Expand/Collapse';
   export let expanded = false;
+  export let href = '/';
+
   import ChevronDown16 from 'carbon-icons-svelte/lib/ChevronDown16';
   import { cx } from '../../../lib';
 
@@ -31,14 +33,14 @@
     role="menuitem"
     tabindex="0"
     aria-label={text}
-    href="javascript:void(0)"
+    {href}
     on:keydown
     on:keydown={({ key }) => {
       if (key === 'Enter') {
         expanded = !expanded;
       }
     }}
-    on:click
+    on:click|preventDefault
     on:mouseover
     on:mouseenter
     on:mouseleave