From ba7eeda7635273ec8da12585bbd130e45d34fc84 Mon Sep 17 00:00:00 2001 From: Eric Liu Date: Sun, 20 Mar 2022 08:18:13 -0700 Subject: [PATCH] breaking: remove deprecated props --- src/Button/Button.svelte | 10 +- src/Button/ButtonSkeleton.svelte | 10 +- src/ContentSwitcher/ContentSwitcher.svelte | 7 - src/DataTable/Table.svelte | 8 - src/NumberInput/NumberInput.svelte | 234 +++++++-------------- src/Search/Search.svelte | 9 +- src/Search/SearchSkeleton.svelte | 8 +- src/StructuredList/StructuredList.svelte | 7 - src/TimePicker/TimePickerSelect.svelte | 9 +- src/UIShell/GlobalHeader/HeaderNav.svelte | 9 +- 10 files changed, 88 insertions(+), 223 deletions(-) diff --git a/src/Button/Button.svelte b/src/Button/Button.svelte index 00f58160..d6375178 100644 --- a/src/Button/Button.svelte +++ b/src/Button/Button.svelte @@ -25,12 +25,6 @@ */ export let isSelected = false; - /** - * Set to `true` for the icon-only variant - * @deprecated inferred using the $$slots API - */ - export let hasIconOnly = false; - /** * Specify the icon to render * @type {typeof import("svelte").SvelteComponent} @@ -44,8 +38,8 @@ export let iconDescription = undefined; /** - * Set the alignment of the tooltip relative to the icon - * `hasIconOnly` must be set to `true` + * Set the alignment of the tooltip relative to the icon. + * Only applies to icon-only buttons * @type {"start" | "center" | "end"} */ export let tooltipAlignment = "center"; diff --git a/src/Button/ButtonSkeleton.svelte b/src/Button/ButtonSkeleton.svelte index c0ec0639..5f7f8c3f 100644 --- a/src/Button/ButtonSkeleton.svelte +++ b/src/Button/ButtonSkeleton.svelte @@ -10,12 +10,6 @@ * @type {"default" | "field" | "small" | "lg" | "xl"} */ export let size = "default"; - - /** - * @deprecated this prop will be removed in the next major release - * Use size="small" instead - */ - export let small = false; @@ -27,7 +21,7 @@ class:bx--skeleton="{true}" class:bx--btn="{true}" class:bx--btn--field="{size === 'field'}" - class:bx--btn--sm="{size === 'small' || small}" + class:bx--btn--sm="{size === 'small'}" class:bx--btn--lg="{size === 'lg'}" class:bx--btn--xl="{size === 'xl'}" {...$$restProps} @@ -43,7 +37,7 @@ class:bx--skeleton="{true}" class:bx--btn="{true}" class:bx--btn--field="{size === 'field'}" - class:bx--btn--sm="{size === 'small' || small}" + class:bx--btn--sm="{size === 'small'}" class:bx--btn--lg="{size === 'lg'}" class:bx--btn--xl="{size === 'xl'}" {...$$restProps} diff --git a/src/ContentSwitcher/ContentSwitcher.svelte b/src/ContentSwitcher/ContentSwitcher.svelte index 81f8d32e..ce7ef662 100644 --- a/src/ContentSwitcher/ContentSwitcher.svelte +++ b/src/ContentSwitcher/ContentSwitcher.svelte @@ -6,12 +6,6 @@ /** Set the selected index of the switch item */ export let selectedIndex = 0; - /** - * Set to `true` to enable the light variant - * @deprecated - */ - export let light = false; - /** * Specify the size of the content switcher * @type {"sm" | "xl"} @@ -67,7 +61,6 @@
@@ -51,7 +44,6 @@ class:bx--data-table--sort="{sortable}" class:bx--data-table--zebra="{zebra}" class:bx--data-table--static="{useStaticWidth}" - class:bx--data-table--no-border="{!shouldShowBorder}" class:bx--data-table--sticky-header="{stickyHeader}" {...$$restProps} > diff --git a/src/NumberInput/NumberInput.svelte b/src/NumberInput/NumberInput.svelte index a7113c97..71e9299d 100644 --- a/src/NumberInput/NumberInput.svelte +++ b/src/NumberInput/NumberInput.svelte @@ -39,12 +39,6 @@ /** Set to `true` for the input to be read-only */ export let readonly = false; - /** - * Set to `true` to enable the mobile variant - * @deprecated - */ - export let mobile = false; - /** Set to `true` to allow for an empty value */ export let allowEmpty = false; @@ -174,158 +168,90 @@ class:bx--number--light="{light}" class:bx--number--nolabel="{hideLabel}" class:bx--number--nosteppers="{hideSteppers}" - class:bx--number--mobile="{mobile}" class="{size && `bx--number--${size}`}" > - {#if mobile} - {#if label} - - {/if} -
- - - -
- {:else} - {#if label} - - {/if} -
- - {#if invalid} - - {/if} - {#if !invalid && warn} - - {/if} - {#if readonly} - - {/if} - {#if !hideSteppers} -
- -
- -
-
- {/if} -
+ {label} + {/if} +
+ + {#if invalid} + + {/if} + {#if !invalid && warn} + + {/if} + {#if readonly} + + {/if} + {#if !hideSteppers} +
+ +
+ +
+
+ {/if} +
{#if !error && !warn && helperText}
- /** - * @deprecated this prop will be removed in the next major release - * Set to `true` to use the small variant - */ - export let small = false; - /** * Specify the size of the search input * @type {"sm" | "lg" | "xl"} @@ -15,7 +9,7 @@
- {labelText} diff --git a/src/UIShell/GlobalHeader/HeaderNav.svelte b/src/UIShell/GlobalHeader/HeaderNav.svelte index 33b68399..91142f4a 100644 --- a/src/UIShell/GlobalHeader/HeaderNav.svelte +++ b/src/UIShell/GlobalHeader/HeaderNav.svelte @@ -1,13 +1,6 @@